[None][infra] Add retry 3 times if ssh cluster failed #6859

EmmaQiaoCh · 2025-08-13T08:49:09Z

Summary by CodeRabbit

Bug Fixes
- Improved reliability of multi-node Slurm jobs by adding automatic retries (3) when transferring the launch script to remote hosts, reducing failures from transient network issues.
Chores
- Updated Jenkins shared library dependency to the latest intended reference for CI workflows.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

coderabbitai · 2025-08-13T08:49:16Z

📝 Walkthrough

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc5f766 and 36c47bf.

📒 Files selected for processing (1)

jenkins/L0_Test.groovy (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (2)

jenkins/L0_Test.groovy (2)

1-1: Avoid pinning the shared library to a personal branch

Using bloom-jenkins-shared-lib@emma/add_slurm_retry_msg introduces fragility (the branch could be deleted or force-pushed). Once the retry support is merged upstream, revert to a stable ref (main, a release tag, or a commit SHA). Also verify that your Jenkins Global Shared Libraries configuration can resolve this branch before merging.

Proposed diff:
-@Library(['bloom-jenkins-shared-lib@emma/add_slurm_retry_msg', 'trtllm-jenkins-shared-lib@main']) _
+@Library(['bloom-jenkins-shared-lib@main',             'trtllm-jenkins-shared-lib@main']) _
If you must pin temporarily, consider using a specific commit SHA for reproducibility. Would you like me to open a tracking issue to revert this once the shared-lib change merges?

396-396: Ensure retries are applied consistently for all dlcluster SSH/SCP operations

I wasn’t able to locate the implementation of Utils.exec in this repo (it appears to live in bloom-jenkins-shared-lib), so please verify that:

Utils.exec(pipeline, …, numRetries: X) is supported for all SSH/SCP calls

It only retries on transport/connectivity errors (not on remote command successes) to avoid double-submitting SLURM jobs

Suggested review targets in jenkins/L0_Test.groovy (when partition.clusterName == "dlcluster"):

Line 331: ssh … 'mkdir …'

Line 339: scp slurm_run.sh

Line 343: scp waives.txt

Line 353: scp generated test list

Line 396: scp scriptLaunchDestPath → already has numRetries: 3

Line 399: ssh … bash ${scriptLaunch} (retry only on SSH failures)

Consider centralizing this logic with a helper, e.g.:
def execWithDLRetry = { Map args ->
  if (partition?.clusterName == "dlcluster") {
    args.numRetries = args.numRetries ?: 3
  }
  Utils.exec(pipeline, args)
}
Please confirm that Utils.exec supports numRetries in all these contexts and that retry logic distinguishes connection failures from successful remote commands.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yuanjingx87

Make sure to switch bsl branch back to main before merging

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-08-19T05:48:43Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-19T05:53:44Z

PR_Github #15723 [ run ] triggered by Bot

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-08-19T08:10:49Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-19T08:15:57Z

PR_Github #15746 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-19T08:15:59Z

PR_Github #15723 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-08-19T09:06:16Z

PR_Github #15746 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #11835 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-08-20T08:46:41Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-20T08:52:25Z

PR_Github #15898 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-20T09:52:15Z

PR_Github #15898 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #11951 (Partly Tested) completed with status: 'FAILURE'

EmmaQiaoCh · 2025-08-20T10:37:31Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-20T10:42:48Z

PR_Github #15914 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-20T11:53:11Z

PR_Github #15914 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #11961 (Partly Tested) completed with status: 'FAILURE'

EmmaQiaoCh · 2025-08-21T06:01:48Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-21T06:07:14Z

PR_Github #16002 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-21T06:41:06Z

PR_Github #16002 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #12028 (Partly Tested) completed with status: 'FAILURE'

EmmaQiaoCh · 2025-08-21T06:44:55Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-21T06:49:56Z

PR_Github #16017 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-21T07:50:59Z

PR_Github #16017 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #12039 (Partly Tested) completed with status: 'FAILURE'

EmmaQiaoCh · 2025-08-21T08:38:30Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-4_GPUs-PyTorch-1"

tensorrt-cicd · 2025-08-21T08:43:39Z

PR_Github #16036 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-21T11:23:36Z

PR_Github #16036 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #12057 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com>

jenkins/L0_Test.groovy

Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Emma Qiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-08-25T15:06:04Z

/bot skip "Add retry for slurm cmd and which is tested in previous CI"

github-actions · 2025-08-25T15:06:13Z