Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 11, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped integration test so it will now run, improving test coverage and increasing chances of catching regressions earlier. No user-facing functionality or APIs changed; no action required from users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 11, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Deleted a single SKIP waiver line from tests/integration/test_lists/waives.txt, re-enabling the examples/test_llama.py::test_llm_api_lookahead_decoding_1gpu[...] integration test.

Changes

Cohort / File(s) Summary of Changes
Test waivers
tests/integration/test_lists/waives.txt
Removed waiver line for examples/test_llama.py::test_llm_api_lookahead_decoding_1gpu[ Llama-3.1-8B-Instruct-llama-3.1-model/Llama-3.1-8B-Instruct ] referencing nvbugs/5419066; no other lines changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • yiqingy0
  • venkywonka

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e31dbfb and df3d755.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xinhe-nv xinhe-nv changed the title Draft: test: [CI] remove closed bugs [None][chore] remove closed bugs Aug 11, 2025
@xinhe-nv xinhe-nv marked this pull request as ready for review August 11, 2025 02:08
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250811 branch from b1cf172 to a5c0e35 Compare August 11, 2025 02:08
@xinhe-nv xinhe-nv requested a review from LarryXFly August 11, 2025 02:08
@xinhe-nv xinhe-nv enabled auto-merge (squash) August 11, 2025 02:08
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14725 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14725 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #11115 completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250811 branch from a5c0e35 to e31dbfb Compare August 11, 2025 05:24
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250811 branch from e31dbfb to bf37c4a Compare August 11, 2025 06:38
@LarryXFly LarryXFly disabled auto-merge August 11, 2025 06:39
@LarryXFly LarryXFly merged commit 9c358c2 into NVIDIA:main Aug 11, 2025
2 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20250811 branch August 21, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants