feat: enhance evaluation notebook fine tuning#395
feat: enhance evaluation notebook fine tuning#395ryan-lempka wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
| "execution_count": null, | ||
| "id": "3ac11757", | ||
| "metadata": {}, | ||
| "outputs": [ |
There was a problem hiding this comment.
qq: how did these logs get removed ?
There was a problem hiding this comment.
@sabhatinas cleared output on the notebook via "Clear All Outputs". Per the RFC currently under review I think we should propose this as a new standard - I don't think the outputs should be uploaded for the following reasons:
1/ Diffs become messy due to variation in output and cell counts from different contributors
2/ They lengthen the notebooks unnecessarily
3/ It's unclear when running a notebook if your cell produced output or if the output was there prior
Aside from these reasons the other example notebooks I have seen elsewhere do the same.
There was a problem hiding this comment.
Got it! As long as this is a conscious choice and we make it the standard, it should be okay.
3 participants
Changes