Fix [PyT/DLRM] bug of model.py - #517
Merged
Merged
Conversation
t-kusanagi
marked this pull request as ready for review
May 19, 2020 00:40
tgrel
suggested changes
May 26, 2020
tgrel
left a comment
Contributor
There was a problem hiding this comment.
I think this will break the code on CPU. My preferred method of fixing this problem would be to pass device=base_device argument here:
@t-kusanagi Would you like to make submit this change yourself as a PR? If not I will fix it in the next release (most likely in a couple of weeks)
Contributor
Author
|
Thank you for your reply. I fixed it as you said and made sure it worked fine in my environment. |
Pass device=base_device argument to self._interaction_padding.
PeganovAnton
pushed a commit
to PeganovAnton/DeepLearningExamples
that referenced
this pull request
Sep 8, 2020
Fix [PyT/DLRM] bug of model.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I executed following command.
and got this error.
torch.catrequires inputs that are on the same device (GPU). I fixed it.