[pull] main from getsentry:main#346
Merged
Merged
Conversation
…554) (#5520) * ref(core): Use static compare and drop redundant null checks Replace boxed Long.valueOf(...).compareTo(...) with Long.compare(...), which avoids the unnecessary boxing. Also remove the redundant != null checks that precede an instanceof, since instanceof already returns false for null. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ref(core): Remove unnecessary boxing (JAVA-554) Replace Integer.valueOf/Double.valueOf boxing with primitives or the appropriate parse method. String.format takes the primitives directly, the double conversions only need a cast, and the version check parses straight to a primitive double via Double.parseDouble. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * changelog * ref(core): Drop redundant StringBuilder in hashing helper (JAVA-554) Return the hex string directly instead of wrapping it in a StringBuilder only to immediately call toString(). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ref(core): Use StandardCharsets.UTF_8 and tidy comments (JAVA-554) Replace Charset.forName("UTF-8") with the StandardCharsets constant, which avoids the lookup and cannot throw a checked exception. Also collapse the leftover hashing comments into one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )