This repository was archived by the owner on Jul 24, 2022. It is now read-only.
Added ReadFile and WriteFile functionality#143
Open
jacobbenlewis wants to merge 2 commits intoNModbus4:portable-3.0from
Open
Added ReadFile and WriteFile functionality#143jacobbenlewis wants to merge 2 commits intoNModbus4:portable-3.0from
jacobbenlewis wants to merge 2 commits intoNModbus4:portable-3.0from
Conversation
…of Encoding to work with .Net core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to be able to read and write files over modbus so I added that functionality. I think it follows the standard correctly and I tried to follow the design patterns in the existing NModbus4 library. Let me know if it looks ok or if I should make any tweaks. Thanks.