This repository was archived by the owner on Jul 24, 2022. It is now read-only.
Permit inheritance of DataStore class#133
Open
61131 wants to merge 4 commits intoNModbus4:portable-3.0from
Open
Permit inheritance of DataStore class#13361131 wants to merge 4 commits intoNModbus4:portable-3.0from
61131 wants to merge 4 commits intoNModbus4:portable-3.0from
Conversation
…ods to be virtual public methods Updated ModbusSlave and unit tests to match
Author
|
It appears that the Travis CI build failure is related to the project upgrade to Visual Studio 2017 (dd47607) and the corresponding removal of NModbus4.UnitTests/project.json. |
…ataStore and SequenceUtility functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a project which I am undertaking, I needed to implement a custom DataStore class for use in association with the NModbus4 library. This however was not possible due to the static nature of the ReadData and WriteData generic methods in the DataStore class. To address this issue I have made the following changes:
For minimal impact, I would propose only merging commit 7f82f61 (Added IDataStore interface class ...)
I would note that this pull request would also address issue #126 (DataStore is not replaceable)