This repository was archived by the owner on Jul 24, 2022. It is now read-only.
Public exception follows .NET guidelines#11
Merged
Maxwe11 merged 2 commits intoNModbus4:masterfrom Mar 4, 2015
Merged
Conversation
Added additional constructors to InvalidModbusRequestException per .NET guidelines. The primary advantage is to allow users to supply an inner exception for their own purposes.
Member
|
LGTM but if you add |
Contributor
Author
|
Good catch. Fixed. I didn't change |
Member
|
LGTM. Thanks |
Maxwe11
added a commit
that referenced
this pull request
Mar 4, 2015
Public exception follows .NET guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional constructors to InvalidModbusRequestException per .NET guidelines. The primary advantage is to allow users to supply an inner exception for their own purposes.