Chore: [AEA-0000] - add standard lifecycle scripts#76
Merged
anthony-nhs merged 4 commits intomainfrom Mar 30, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR makes git-secrets configuration idempotent and moves it to devcontainer creation time so it applies consistently on fresh clones without re-running on every attach.
Changes:
- Add
scripts/install-git-secrets.shto register AWS patterns and add the NHSD deny-list provider only if not already configured. - Update devcontainer lifecycle hook from
postAttachCommandtopostCreateCommandto avoid repeated configuration on every start/attach.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/install-git-secrets.sh |
New script to configure git-secrets patterns/providers only when missing. |
.devcontainer/devcontainer.json |
Runs the new script during postCreateCommand instead of configuring git-secrets on attach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anthony-nhs
reviewed
Mar 30, 2026
tstephen-nhs
changed the title
anthony-nhs
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details