Breaking: [AEA-0000] - Use zizmor and anchore tools#118
Open
anthony-nhs wants to merge 45 commits intomainfrom
Open
Breaking: [AEA-0000] - Use zizmor and anchore tools#118anthony-nhs wants to merge 45 commits intomainfrom
anthony-nhs wants to merge 45 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR introduces zizmor configuration for GitHub Actions security/linting and updates several workflows to address findings (credential persistence, secret handling patterns, and safer variable interpolation).
Changes:
- Add
zizmor.ymlwith rule configuration and ignore locations. - Update multiple workflows to adjust
actions/checkoutcredential persistence and to move${{ }}interpolations into environment variables in shell steps. - Remove the “Combine Dependabot PRs” reusable workflow and its supporting
combine-prs.jsscript.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
zizmor.yml |
Adds zizmor rule config and ignore list for existing workflow findings. |
combine-prs.js |
Removes the JS helper that implemented PR-combining logic. |
.github/workflows/update-dev-container-version.yml |
Disables persisted checkout credentials; refactors version interpolation to env var usage. |
.github/workflows/tag-release-devcontainer.yml |
Adjusts checkout credential persistence and uses env var interpolation for shell safety. |
.github/workflows/release.yml |
Removes secrets: inherit from reusable workflow call. |
.github/workflows/quality-checks-devcontainer.yml |
Disables persisted checkout credentials; uses env var in logging step. |
.github/workflows/pull_request.yml |
Removes secrets: inherit from reusable workflow call. |
.github/workflows/get-repo-config.yml |
Disables persisted checkout credentials. |
.github/workflows/dependabot-auto-approve-and-merge.yml |
Tightens job gating condition to bot PR author + non-fork constraint. |
.github/workflows/combine-dependabot-prs.yml |
Removes the reusable workflow that created a combined Dependabot PR. |
.devcontainer/devcontainer.json |
Updates the devcontainer base image version reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anthony-nhs
changed the title
anthony-nhs
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/tag-release-devcontainer.yml:89
.gitallowedstill allowlistsid-token: write(unquoted), but this workflow uses quoted permissions (id-token: "write",contents: "write"). If your secret-scanning step relies on.gitallowed, this quoted form may now be flagged after the allowlist lines for quoted variants were removed. Either switch to unquotedwritehere (matching other workflows) or re-add the quoted allowlist patterns if quotes are required.
tag_release:
permissions:
id-token: "write"
contents: "write"
runs-on: ubuntu-22.04
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details