Chore: [AEA-6258] - Set the defaultValue to default to undefined#645
Merged
Chore: [AEA-6258] - Set the defaultValue to default to undefined#645
defaultValue to default to undefined#645Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6258 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CDK constructs config helpers so the defaultValue parameter is optional by explicitly defaulting it to undefined, aligning the API with existing call sites and the similar helpers in deploymentUtils.
Changes:
- Set
defaultValueparameter default toundefinedingetConfigFromEnvVar. - Apply the same defaulting to
getBooleanConfigFromEnvVarandgetNumberConfigFromEnvVar.
tstephen-nhs
approved these changes
Mar 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary