NHSDigital
diff --git a/‎codonPython/nhsNumberGenerator.py‎
Lines changed: 13 additions & 3 deletions b/‎codonPython/nhsNumberGenerator.py‎
Lines changed: 13 additions & 3 deletions
diff --git a/‎codonPython/tests/nhsNumberGenerator_test.py‎
Lines changed: 9 additions & 0 deletions b/‎codonPython/tests/nhsNumberGenerator_test.py‎
Lines changed: 9 additions & 0 deletions
@@ -3,7 +3,7 @@
 
 def nhsNumberGenerator(to_generate: int, random_state: int = None)->list:
     """
-    Generates random NHS number(s) compliant with modulus 11 checks recorded 
+    Generates up to 1M random NHS number(s) compliant with modulus 11 checks recorded 
     in the data dictonary.
     https://www.datadictionary.nhs.uk/data_dictionary/attributes/n/nhs/nhs_number_de.asp?shownav=1
 
@@ -12,7 +12,7 @@ def nhsNumberGenerator(to_generate: int, random_state: int = None)->list:
     to_generate : int
         number of NHS numbers to generate
     random_state : int, default : None
-        Optional seed for random number generation, for testing and reproducability.
+        Optional seed for random number generation, for testing and reproducibility.
 
     Returns
     ----------
@@ -27,7 +27,13 @@ def nhsNumberGenerator(to_generate: int, random_state: int = None)->list:
 
     if random_state:
         random.seed(random_state)
-        
+    if not isinstance(to_generate, int) :
+        raise ValueError("Please input a positive integer to generate numbers.")
+    if to_generate > 1000000 :
+        raise ValueError("More than one million values requested")
+    if to_generate < 0:
+        raise ValueError("Please input a postitive integer to generate numbers.")
+
     generated = []
     while len(generated) < to_generate:
         # Random 9 digit number starting with non-zero digit
@@ -41,3 +47,7 @@ def nhsNumberGenerator(to_generate: int, random_state: int = None)->list:
             number = int(str(number) + "0")
             generated.append(number)
     return generated
+
+    import numpy as np
+    nhsNumberGenerator(np.inf)
+    nhsNumberGenerator(4.2)
@@ -10,3 +10,12 @@
 ])
 def test_nhsNumberGenerator_BAU(to_generate, random_state, expected):
     assert expected == nhsNumberGenerator(to_generate, random_state=random_state) 
+
+@pytest.mark.parametrize("to_generate", [
+    4.2,
+    1000001,
+    -1
+])
+def test_nhsNumberGenerator_valueErrors(to_generate):  
+    with pytest.raises(ValueError): 
+        nhsNumberGenerator(to_generate)