Fixed unit tests#14
Closed
wcmatthysen wants to merge 4 commits intoNASAWorldWind:masterfrom
wcmatthysen:fixed-unit-tests
Closed
Fixed unit tests#14wcmatthysen wants to merge 4 commits intoNASAWorldWind:masterfrom wcmatthysen:fixed-unit-tests
wcmatthysen wants to merge 4 commits intoNASAWorldWind:masterfrom
wcmatthysen:fixed-unit-tests
Conversation
Fixed the permissions of the image and source files. Image and source files should not have their executable-bit set.
Removed the embedded jackon source code and added jackson-core-asl.jar instead (we use version 1.9.6). Changed the build.xml file to reference this jar during the compilation process.
Executing the unit tests from the command-line using ant resulted in a lot of failed tests. To fix this a number of changes had to be made: - Modified the unit tests containing nested test classes by adding an @RunWith(Enclosed.class) annotation at the top. - Added an @ignore annotation to the HighResolutionTerrainTest2 as this test is currently failing. Also, added @ignore annotations for IconRetrievalTest and PointGraphicRetrievalTest as these tests take too long to execute. - Made some changes to the run.tests ant-target in test.xml. Firstly, we added an option to print the test-summary to give more detailed output during test execution. Then, added an exclusion clause for all nested test classes ("**/*$*.class"). This ensures that tests are not executed twice when using the Enclosed test-runner. Added additional exclusion clauses for classes that are not unit-tests. - Added a clause to test.xml that generates a junit test-report for us. The report is stored in HTML format in the testReports directory.
|
wcmatthysen, Thank you very much for contributing these changes. After reviewing this pull request, the NASA World Wind team found that the unit tests were in need of updating, and that the MIL-STD-2525 image sources (which you found had executable bits set) needed to be rearranged in the SDK. Given that, we've taken your pull request as a recommendation and have implemented changes that address the root problems. In the short term, we've kept the embedded Jackson sources. We plan to migrate World Wind Java to a modern build system, and will externalize the Jackson sources when we do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a forked mavenized repository of WorldWind with a lot of changes that I made over the years as I was using WorldWind in a project. These include nice additional classes like an offscreen WorldWind canvas as well as a lot of smaller changes that improves the usability of WorldWind that accumulated over time. I want to contribute all of those changes here and perhaps help to mavenize WorldWind. I felt the best way is to start small with a couple of cleanups as well as fixing the unit-test so that we can run them from the command-line: