Change "World Wind" to "WorldWind" by eirizarry · Pull Request #129 · NASAWorldWind/WorldWindJava

eirizarry · 2017-08-21T21:42:40Z

Description of the Change

All instances of "World Wind" in the source code comments and supporting documentation have been changed to "WorldWind".

Why Should This Be In Core?, Benefits

This pull request is necessary to make "WorldWind" the consistent project name. It is part of a larger epic which updates the documentation in WorldWind Java's repository.

Closes #121, closes #125.

Potential Drawbacks

Many files were modified, which may require more time spent on the review process.

Applicable Issues

- All instances of "World Wind" in the source code and supporting documents have been changed to "WorldWind"

pdavidc

Overall this change looks great. The majority of these changes affect comments, documentation, and examples. I've commented on code changes in the core library, simply to indicate that we've identified them and that they're okay.

pdavidc · 2017-08-28T17:41:09Z

README.md

 ## License

-    NASA WORLD WIND
+    NASA WorldWind


Change needed: Let's keep the uppercase WORLDWIND found in license files.

pdavidc · 2017-08-28T17:48:32Z

build.xml

                 overview="${worldwind.src.dir}/overview.html"
                 encoding="UTF-8"
-                 windowtitle="NASA World Wind" doctitle="NASA World Wind" header="NASA World Wind"
+                 windowtitle="NASA WorldWind" doctitle="NASA WorldWind" header="NASA WorldWind"


Note: These JavaDoc arguments affect the documentation displayed at https://worldwind.arc.nasa.gov/java/docs/

pdavidc · 2017-08-28T17:49:45Z

src/gov/nasa/worldwind/Version.java

    private static final String DOT_VALUE = "0";
    private static final String versionNumber = "v" + MAJOR_VALUE + "." + MINOR_VALUE + "." + DOT_VALUE;
-    private static final String versionName = "NASA World Wind Java";
+    private static final String versionName = "NASA WorldWind Java";


Note: Safe code change. The version name is not considered backward compatible.

pdavidc · 2017-08-28T17:50:41Z

src/gov/nasa/worldwind/formats/gpx/GpxWriter.java

            org.w3c.dom.Element gpx = doc.createElement("gpx");
            gpx.setAttribute("version", "1.1");
-            gpx.setAttribute("creator", "NASA World Wind");
+            gpx.setAttribute("creator", "NASA WorldWind");


Note: Safe code change. The GPX "creator" attribute is not considered backward compatible.

pdavidc · 2017-08-28T17:51:22Z

src/gov/nasa/worldwind/formats/vpf/GeoSymAttributeConverter.java

        System.out.println();
        System.out.println("Converts GeoSym line attributes, area attributes, and area patterns into a form usable by");
-        System.out.println("World Wind VPF shapes. Outputs to \"" + OUT_DIR + "\" a comma-separated-value file");
+        System.out.println("WorldWind VPF shapes. Outputs to \"" + OUT_DIR + "\" a comma-separated-value file");


Note: Safe code change. Console output from a VPF command line utility.

pdavidc · 2017-08-28T17:55:33Z

src/gov/nasa/worldwind/util/MessageStrings.properties

 BasicRetrievalService.ExecutionExceptionDuringRetrieval=Execution exception during retrieval of {0}
 BasicRetrievalService.ExceptionRetrievingContentSizes=Exception retrieving content sizes from Retriever {0}
-BasicRetrievalService.IdleThreadNamePrefix=Idle World Wind Retriever
+BasicRetrievalService.IdleThreadNamePrefix=Idle WorldWind Retriever


Note: Safe code changes. These message strings indicate thread group names and logger content.

pdavidc · 2017-08-28T17:57:40Z

src/gov/nasa/worldwindx/applications/sar/worldwind-nosa-1.3.html

 <tbody>
 <tr>
-<td><p class="style14"><span class="style4"> NASA WORLD WIND </span></p>
+<td><p class="style14"><span class="style4"> NASA WorldWind </span></p>


Change needed: Let's keep the uppercase WORLDWIND found in license files.

pdavidc · 2017-08-28T18:25:27Z

Design and Coding Guidelines.html

@@ -6,7 +6,7 @@



Change needed: This file has a conflict with a develop branch.

* Updated urls in documentation to use HTTPS wherever possible * Updated forum links to use HTTPS protocol * Repaired intermittent unit test failures due to random values * Repaired Travis CI build's broken link to Apache ANT binary * Corrected SurfaceText handling of cached extent. Fixes and closes #28. * Modified the ANT build to correctly assemble the release JAR files. Fixes #87. * README adjustments for new continuous integration - Simplified the opening paragraph and combined it with the Get Started section. Removed unnecessary GitHub issues link. - Updated the Releases and Roadmap section to reflect the new continuous integration structure. - Removed Daily Builds section, as daily builds have been shut down. Daily builds are expected to be replaced with a simple snapshot link in the Download section. - Removed API documentation links to decouple the website structure from the README file. * Travis CI adjustments for new continuous integration - Removed daily builds, which are scheduled to be replaced by Maven SNAPSHOT artifacts - Removed Javadoc publication to the World Wind website, which is now handled independently by the website itself - Modularized the change log script for interoperability with other World Wind repositories - Simplified Travis CI deployment tasks to reduce redundancy * Travis CI adjustments - Updated Travis CI to notify the World Wind team mailing list on every build * Corrected copy and paste typos in Travis CI configuration * Travis CI adjustments - Adjusted changelog.sh for TRAVIS build environment - Removed obsolete keystore and its decryption commands * Removed unnecessary entry from .gitignore * Restored default Travis CI notifications (#118) - Removed the custom notifications block from .travis.yml - Notifying everyone on every build is now unnecessary, as GitHub protected branches and mandatory pull requests ensure that only successful builds make it into the develop and master branches - Install the Ant JUnit packages missing from the Travis CI environment. - Closes #113 * Excluded local project files and build output - Updated .gitignore for project files per IntelliJ guidelines: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems - Eliminates spurious changes to project files from Android Studio automatic changes. * Update WorldWind Java documentation (#128) - Added ISSUE_TEMPLATE.md, which gives the guidelines for submitting an issue - Added PULL_REQUEST_TEMPLATE.md, which gives the guidelines for submitting a pull request - Added CONTRIBUTING.md, which gives the overall expectations for contributing to WorldWind Java, the coding and design guidelines, and resources for the WorldWind community - Removed "Design and Coding Guidelines.html"; this file's content was ported into CONTRIBUTING.md * Change "World Wind" to "WorldWind" (#129) All instances of "World Wind" in the source code and supporting documents have been changed to "WorldWind" * Fix broken NASA logo reference (#140) Path to NASA logo in README was broken, as our website infrastructure changed. It has been fixed. * Publish API documentation to gh-pages on every push to develop * Update README.md * Disabled Travis CI deployment in preparation for project suspension (#165) * Update README.md * Notice update * Notice alignment * Notice update * JDK version update * Build fix * JOGL and Java 11+ updates * Updated JOGL/GlueGen libs * Added jogl windows natives * Remove outdated jars * JOGL for OSX * Remove Scankort demo * Remove nbproject/private folder * Travis build fix * Travis build fix * Removed webstart build, fixed javadoc * Javadoc fixes * Javadoc fixes * Travis build fix * Javadoc fix * Remove local folder references * Test change * Test change * Test change * Test change * Move to JDK 11 and latest JOGL 2.4 on Linux * Update ISSUE_TEMPLATE.md (#170) File mistakenly linked to Web WorldWind resources. * JOGL 2.4 for Windows * JOGL for OSX * Update the code formatting to be more conformant * Revert "Update the code formatting to be more conformant" * Polyline deprecation fixes * Polyline deprecation fixes * Polyline deprecation fixes * Deprecation fixes * Deprecation/Lint fixes * Revert Polyline formatting * Formatting adjustments * GeoRSS fixes * Deprecation bug fixes * Build fixes * Logging run config * WebView deprecation * Moved Collada examples back to test code * Removed Collada code from incorrect location * JOGL refresh (#199) * Add jackson license (#202) * Add gdal license (#203) * WWMath unit test (#205) * License and release updates (#206) * Final release adjustments (#207) * Final release adjustments * Title adjustment Co-authored-by: pdavidc <paul@paulcollinssoftware.com> Co-authored-by: Zach Glueckert <zachary.r.glueckert@nasa.gov> Co-authored-by: eirizarry <endiajanae@mail.fresnostate.edu> Co-authored-by: Bruce Schubert <bruce@emxsys.com> Co-authored-by: markpet49 <mark.e.peterson@nasa.gov> Co-authored-by: Miguel Del Castillo <migueldelcastillo@live.com> Co-authored-by: markpet49 <mpeterson@farmintelligence.com>

* Updated urls in documentation to use HTTPS wherever possible * Updated forum links to use HTTPS protocol * Repaired intermittent unit test failures due to random values * Repaired Travis CI build's broken link to Apache ANT binary * Corrected SurfaceText handling of cached extent. Fixes and closes WorldWindEarth#28. * Modified the ANT build to correctly assemble the release JAR files. Fixes WorldWindEarth#87. * README adjustments for new continuous integration - Simplified the opening paragraph and combined it with the Get Started section. Removed unnecessary GitHub issues link. - Updated the Releases and Roadmap section to reflect the new continuous integration structure. - Removed Daily Builds section, as daily builds have been shut down. Daily builds are expected to be replaced with a simple snapshot link in the Download section. - Removed API documentation links to decouple the website structure from the README file. * Travis CI adjustments for new continuous integration - Removed daily builds, which are scheduled to be replaced by Maven SNAPSHOT artifacts - Removed Javadoc publication to the World Wind website, which is now handled independently by the website itself - Modularized the change log script for interoperability with other World Wind repositories - Simplified Travis CI deployment tasks to reduce redundancy * Travis CI adjustments - Updated Travis CI to notify the World Wind team mailing list on every build * Corrected copy and paste typos in Travis CI configuration * Travis CI adjustments - Adjusted changelog.sh for TRAVIS build environment - Removed obsolete keystore and its decryption commands * Removed unnecessary entry from .gitignore * Restored default Travis CI notifications (NASAWorldWind#118) - Removed the custom notifications block from .travis.yml - Notifying everyone on every build is now unnecessary, as GitHub protected branches and mandatory pull requests ensure that only successful builds make it into the develop and master branches - Install the Ant JUnit packages missing from the Travis CI environment. - Closes NASAWorldWind#113 * Excluded local project files and build output - Updated .gitignore for project files per IntelliJ guidelines: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems - Eliminates spurious changes to project files from Android Studio automatic changes. * Update WorldWind Java documentation (NASAWorldWind#128) - Added ISSUE_TEMPLATE.md, which gives the guidelines for submitting an issue - Added PULL_REQUEST_TEMPLATE.md, which gives the guidelines for submitting a pull request - Added CONTRIBUTING.md, which gives the overall expectations for contributing to WorldWind Java, the coding and design guidelines, and resources for the WorldWind community - Removed "Design and Coding Guidelines.html"; this file's content was ported into CONTRIBUTING.md * Change "World Wind" to "WorldWind" (NASAWorldWind#129) All instances of "World Wind" in the source code and supporting documents have been changed to "WorldWind" * Fix broken NASA logo reference (NASAWorldWind#140) Path to NASA logo in README was broken, as our website infrastructure changed. It has been fixed. * Publish API documentation to gh-pages on every push to develop * Update README.md * Disabled Travis CI deployment in preparation for project suspension (NASAWorldWind#165) * Update README.md * Notice update * Notice alignment * Notice update * JDK version update * Build fix * JOGL and Java 11+ updates * Updated JOGL/GlueGen libs * Added jogl windows natives * Remove outdated jars * JOGL for OSX * Remove Scankort demo * Remove nbproject/private folder * Travis build fix * Travis build fix * Removed webstart build, fixed javadoc * Javadoc fixes * Javadoc fixes * Travis build fix * Javadoc fix * Remove local folder references * Test change * Test change * Test change * Test change * Move to JDK 11 and latest JOGL 2.4 on Linux * Update ISSUE_TEMPLATE.md (NASAWorldWind#170) File mistakenly linked to Web WorldWind resources. * JOGL 2.4 for Windows * JOGL for OSX * Update the code formatting to be more conformant * Revert "Update the code formatting to be more conformant" * Polyline deprecation fixes * Polyline deprecation fixes * Polyline deprecation fixes * Deprecation fixes * Deprecation/Lint fixes * Revert Polyline formatting * Formatting adjustments * GeoRSS fixes * Deprecation bug fixes * Build fixes * Logging run config * WebView deprecation * Moved Collada examples back to test code * Removed Collada code from incorrect location * JOGL refresh (NASAWorldWind#199) * Add jackson license (NASAWorldWind#202) * Add gdal license (NASAWorldWind#203) * WWMath unit test (NASAWorldWind#205) * License and release updates (NASAWorldWind#206) * Final release adjustments (NASAWorldWind#207) * Final release adjustments * Title adjustment Co-authored-by: pdavidc <paul@paulcollinssoftware.com> Co-authored-by: Zach Glueckert <zachary.r.glueckert@nasa.gov> Co-authored-by: eirizarry <endiajanae@mail.fresnostate.edu> Co-authored-by: Bruce Schubert <bruce@emxsys.com> Co-authored-by: markpet49 <mark.e.peterson@nasa.gov> Co-authored-by: Miguel Del Castillo <migueldelcastillo@live.com> Co-authored-by: markpet49 <mpeterson@farmintelligence.com>

Change "World Wind" to "WorldWind"

0685d61

- All instances of "World Wind" in the source code and supporting documents have been changed to "WorldWind"

eirizarry requested a review from pdavidc August 21, 2017 21:42

ghost assigned eirizarry Aug 21, 2017

ghost added the needs review label Aug 21, 2017

pdavidc suggested changes Aug 28, 2017

View reviewed changes

eirizarry added 2 commits August 28, 2017 13:46

Change "WorldWind" in LICENSE files

961b556

Resolve merge conflict with develop

3e9a191

pdavidc approved these changes Aug 28, 2017

View reviewed changes

pdavidc merged commit 1532580 into develop Aug 28, 2017

ghost removed the needs review label Aug 28, 2017

pdavidc deleted the feature/worldwind-name branch August 28, 2017 22:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change "World Wind" to "WorldWind"#129

Change "World Wind" to "WorldWind"#129
pdavidc merged 3 commits intodevelopfrom
feature/worldwind-name

eirizarry commented Aug 21, 2017

Uh oh!

pdavidc left a comment •

edited

Loading

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

pdavidc Aug 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

eirizarry commented Aug 21, 2017

Description of the Change

Why Should This Be In Core?, Benefits

Potential Drawbacks

Applicable Issues

Uh oh!

pdavidc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

pdavidc left a comment •

edited

Loading