Use Log#log(Level, String, Throwable).

Ben Bader · Ben Bader · commit ec4eb62a815f · 2014-10-13T11:22:17.000-07:00
Additionaly, increase log level of exceptions from FINE to WARNING.
diff --git a/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java b/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java
@@ -31,7 +31,6 @@
 import org.msgpack.template.Template;
 import org.msgpack.template.AbstractTemplate;
 import org.msgpack.template.TemplateRegistry;
-import org.msgpack.util.Exceptions;
 
 @SuppressWarnings({ "rawtypes", "unchecked" })
 public class JavassistTemplateBuilder extends AbstractTemplateBuilder {
@@ -74,9 +73,8 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {
                 appended = true;
             }
         } catch (SecurityException e) {
-            if (LOG.isLoggable(Level.FINE)) {
-                LOG.fine("Cannot append a search path of classloader");
-                LOG.fine(Exceptions.getStackTraceAsString(e));
+            if (LOG.isLoggable(Level.WARNING)) {
+                LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);
             }
         }
         if (!appended) {
diff --git a/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java b/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java
@@ -26,7 +26,6 @@
 import java.util.logging.Logger;
 
 import org.msgpack.template.TemplateRegistry;
-import org.msgpack.util.Exceptions;
 import org.msgpack.util.android.DalvikVmChecker;
 
 public class TemplateBuilderChain {
@@ -87,8 +86,8 @@ private static TemplateBuilder createForceTemplateBuilder(String className,
                     ClassLoader.class);
             return (TemplateBuilder) cons.newInstance(registry, cl);
         } catch (Exception e) {
-            if (LOG.isLoggable(Level.FINE)) {
-                LOG.fine(Exceptions.getStackTraceAsString(e));
+            if (LOG.isLoggable(Level.WARNING)) {
+                LOG.log(Level.WARNING, "Failed to create a TemplateBuilder reflectively", e);
             }
         }
         return new ReflectionTemplateBuilder(registry, cl);
diff --git a/src/main/java/org/msgpack/util/Exceptions.java b/src/main/java/org/msgpack/util/Exceptions.java

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@`
`31`	`31`	`import org.msgpack.template.Template;`
`32`	`32`	`import org.msgpack.template.AbstractTemplate;`
`33`	`33`	`import org.msgpack.template.TemplateRegistry;`
`34`		`-import org.msgpack.util.Exceptions;`
`35`	`34`
`36`	`35`	`@SuppressWarnings({ "rawtypes", "unchecked" })`
`37`	`36`	`public class JavassistTemplateBuilder extends AbstractTemplateBuilder {`
`@@ -74,9 +73,8 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {`
`74`	`73`	`appended = true;`
`75`	`74`	`}`
`76`	`75`	`} catch (SecurityException e) {`
`77`		`- if (LOG.isLoggable(Level.FINE)) {`
`78`		`- LOG.fine("Cannot append a search path of classloader");`
`79`		`- LOG.fine(Exceptions.getStackTraceAsString(e));`
	`76`	`+ if (LOG.isLoggable(Level.WARNING)) {`
	`77`	`+ LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);`
`80`	`78`	`}`
`81`	`79`	`}`
`82`	`80`	`if (!appended) {`