Replacing calls to Exception#printStackTrace() with Java logging.

Ben Bader · Ben Bader · commit 407caaec82be · 2014-10-02T15:11:59.000-07:00
This will keep output cleaner, especially in Android where logging and stdout are mixed.
diff --git a/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java b/src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java
@@ -31,6 +31,7 @@
 import org.msgpack.template.Template;
 import org.msgpack.template.AbstractTemplate;
 import org.msgpack.template.TemplateRegistry;
+import org.msgpack.util.Exceptions;
 
 @SuppressWarnings({ "rawtypes", "unchecked" })
 public class JavassistTemplateBuilder extends AbstractTemplateBuilder {
@@ -73,8 +74,10 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {
                 appended = true;
             }
         } catch (SecurityException e) {
-            LOG.fine("Cannot append a search path of classloader");
-            e.printStackTrace();
+            if (LOG.isLoggable(Level.FINE)) {
+                LOG.fine("Cannot append a search path of classloader");
+                LOG.fine(Exceptions.getStackTraceAsString(e));
+            }
         }
         if (!appended) {
             pool.appendSystemPath();
diff --git a/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java b/src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java
@@ -22,11 +22,16 @@
 import java.lang.reflect.Type;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import org.msgpack.template.TemplateRegistry;
+import org.msgpack.util.Exceptions;
 import org.msgpack.util.android.DalvikVmChecker;
 
 public class TemplateBuilderChain {
+	private static final Logger LOG = Logger.getLogger(TemplateBuilderChain.class.getName());
+
 	private static final String JAVASSIST_TEMPLATE_BUILDER_CLASS_NAME =
 			"org.msgpack.template.builder.JavassistTemplateBuilder";
 	private static final String REFLECTION_TEMPLATE_BUILDER_CLASS_NAME =
@@ -82,7 +87,9 @@ private static TemplateBuilder createForceTemplateBuilder(String className,
 					ClassLoader.class);
 			return (TemplateBuilder) cons.newInstance(registry, cl);
 		} catch (Exception e) {
-		    e.printStackTrace();
+			if (LOG.isLoggable(Level.FINE)) {
+				LOG.fine(Exceptions.getStackTraceAsString(e));
+			}
 		}
         return new ReflectionTemplateBuilder(registry, cl);
     }
diff --git a/src/main/java/org/msgpack/util/Exceptions.java b/src/main/java/org/msgpack/util/Exceptions.java
@@ -0,0 +1,18 @@
+package org.msgpack.util;
+
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
+public class Exceptions {
+    /**
+     * Prints an exception as a {@link String} suitable for logging.
+     *
+     * @param e the exception to print
+     * @return the exception formatted as a string
+     */
+    public static String getStackTraceAsString(Exception e) {
+        StringWriter writer = new StringWriter();
+        e.printStackTrace(new PrintWriter(writer));
+        return writer.toString();
+    }
+}
