Commits

Breadcrumbs

History for

onmaster

User selector

All users

All time

Commit History

Commits on Apr 18, 2019

• Fix typo.

  Show description for fd231d9
  

  netdpb

  authored and

  ronshapiro

  committed
  fd231d9

  Copy full SHA for fd231d9

• Do full binding graph validation for components and subcomponents.

  Show description for 15d20f8
  

  netdpb

  authored and

  ronshapiro

  committed
  15d20f8

  Copy full SHA for 15d20f8

• Enable GoodTime-API for Dagger

  Show description for 5d6fa23
  

  kluever

  authored and

  ronshapiro

  committed
  5d6fa23

  Copy full SHA for 5d6fa23

• Add @FormatMethod to a format method.

  Show description for 49c072d
  

  cgdecker

  authored and

  ronshapiro

  committed
  49c072d

  Copy full SHA for 49c072d

• Pass SubcomponentDeclarations instead of TypeElements to SubcomponentCreatorBindingEdgeImpl.

  Show description for 7e374b5
  ronshapiro

  committed
  7e374b5

  Copy full SHA for 7e374b5

Commits on Apr 16, 2019

• Don't format generated code by default

  Show description for fcd069c
  ronshapiro

  committed
  fcd069c

  Copy full SHA for fcd069c

• Update to Bazel 0.24.1 and fix a few things that came up during upgrading

  Show description for f1d4925
  ronshapiro

  committed
  f1d4925

  Copy full SHA for f1d4925

• Make parseOption methods non-static so they can cache their results, so we don't report an error more than once per option.

  Show description for 645f5d7
  

  netdpb

  authored and

  ronshapiro

  committed
  645f5d7

  Copy full SHA for 645f5d7

• Add a simple framework to collect Dagger codebase stats using ErrorProne

  Show description for 3dcff26
  ronshapiro

  committed
  3dcff26

  Copy full SHA for 3dcff26

Commits on Apr 10, 2019

• Serialize metadata about the binding graph in abstract component implementations

  Show description for bb1a466
  ronshapiro

  committed
  bb1a466

  Copy full SHA for bb1a466

• Replace AutoValue-based CompilerOptions with one that parses the options on demand. Simplifies compiler options code.

  Show description for 4f4dc41
  

  netdpb

  authored and

  ronshapiro

  committed
  4f4dc41

  Copy full SHA for 4f4dc41

• Allow Dagger options to be set using an annotation, @DaggerOptions.

  Show description for 6b51a67
  

  bcorso

  authored and

  ronshapiro

  committed
  6b51a67

  Copy full SHA for 6b51a67

• Refactor and expose module and component annotations as static final fields.

  Show description for 81e4fc9
  

  bcorso

  authored and

  ronshapiro

  committed
  81e4fc9

  Copy full SHA for 81e4fc9

• Make Java 7 compatibility work-arounds conditional on the source version

  Show description for 188160a
  

  cushon

  authored and

  ronshapiro

  committed
  188160a

  Copy full SHA for 188160a

Commits on Apr 2, 2019

• Fix an issue where @BindsInstance on a Builder setter method's parameter caused a failure in codegen if the parameter had a different name than the setter method.

  Show description for 8051d28
  cgdecker

  committed
  8051d28

  Copy full SHA for 8051d28

• Refactor CompilerOptions in advance of supporting option aliases (for a renaming).

  Show description for d68e8ba
  

  netdpb

  authored and

  ronshapiro

  committed
  d68e8ba

  Copy full SHA for d68e8ba

• Change ComponentCreatorAnnotation into an enum for simplification. (Reduces use of ComponentKind enum.)

  Show description for 5e9bc77
  

  netdpb

  authored and

  ronshapiro

  committed
  5e9bc77

  Copy full SHA for 5e9bc77

• Simple refactoring of ComponentProcessingStep in advance of another CL to add full binding graph validation for subcomponents and components.

  Show description for 3c83f5f
  

  netdpb

  authored and

  ronshapiro

  committed
  3c83f5f

  Copy full SHA for 3c83f5f

Commits on Mar 28, 2019

• Allow @BindsInstance on parameters of builder methods, with the same results as putting the annotation on the method itself. @BindsInstance may not be present on both the method and the parameter; …

  Show description for 60dc2a6
  

  cgdecker

  authored and

  ronshapiro

  committed
  60dc2a6

  Copy full SHA for 60dc2a6

• Replace ComponentMethodDescriptor.kind() (and the enum) with subcomponent() for subcomponent factory or creator methods. Simplifies a bunch of code.

  Show description for 61a77a9
  

  netdpb

  authored and

  ronshapiro

  committed
  61a77a9

  Copy full SHA for 61a77a9

• Replace static methods in ConfigurationAnnotations with a ComponentAnnotation type representing information in a @Component, @ProductionComponent, @Subcomponent, or @ProductionSubcomponent annotati…

  Show description for cb64548
  

  netdpb

  authored and

  ronshapiro

  committed
  cb64548

  Copy full SHA for cb64548

Commits on Mar 22, 2019

• Add @since 2.22 to @Component.Factory and friends.

  Show description for f985e9b
  

  cgdecker

  authored and

  ronshapiro

  committed
  f985e9b

  Copy full SHA for f985e9b

• Reorder a condition in InjectBindingRegistryImpl

  Show description for 51a3375
  ronshapiro

  committed
  51a3375

  Copy full SHA for 51a3375

Commits on Mar 20, 2019

• Fix BindingGraphPlugin#initElements javadoc.

  Show description for 650f3c1
  

  ruli

  authored and

  cgdecker

  committed
  650f3c1

  Copy full SHA for 650f3c1

• Don't check visibility of includes on module types that are public, but not effectively public (because they're nested in a non-public type).

  Show description for a647c14
  cgdecker

  committed
  a647c14

  Copy full SHA for a647c14

• Index BindingGraph nodes by Class so that we don't need to loop over each repeatedly each time.

  Show description for 9924ac4
  

  ronshapiro

  authored and

  cgdecker

  committed
  9924ac4

  Copy full SHA for 9924ac4

Commits on Mar 17, 2019

• Begin to use @Subcomponent.Factory in dagger.android

  Show description for 2c0b7a0
  ronshapiro

  committed
  2c0b7a0

  Copy full SHA for 2c0b7a0

• Small ternary simplification

  Show description for 4709119
  ronshapiro

  committed
  4709119

  Copy full SHA for 4709119

• Use the ComponentDescriptor directly instead of going through the BindingGraph.

  Show description for 8996cfd
  ronshapiro

  committed
  8996cfd

  Copy full SHA for 8996cfd

• github.com/google/kythe -> github.com/kythe/kythe

  Show description for 623bab9
  

  justbuchanan

  authored and

  ronshapiro

  committed
  623bab9

  Copy full SHA for 623bab9

• Allow public modules to include non-public modules when those included modules do not require an instance: that is, they only have abstract and/or static binding methods.

  Show description for bfdecad
  

  cgdecker

  authored and

  ronshapiro

  committed
  bfdecad

  Copy full SHA for bfdecad

• Small change to logic for ComponentRequirement.requiresAPassedInstance.

  Show description for 3ddfa8b
  

  cgdecker

  authored and

  ronshapiro

  committed
  3ddfa8b

  Copy full SHA for 3ddfa8b

• Create a factory methods for ComponentImplementations instead of calling constructors directly.

  Show description for dbfd1cd
  ronshapiro

  committed
  dbfd1cd

  Copy full SHA for dbfd1cd

• Don't create MethodSpecs with bodies for methods that are modifiable and do not have a base class implementation.

  Show description for a5b7273
  ronshapiro

  committed
  a5b7273

  Copy full SHA for a5b7273

• Extract a method to make a future refactoring simpler

  Show description for 7392f8b
  ronshapiro

  committed
  7392f8b

  Copy full SHA for 7392f8b