DatePicker: Ability to navigate datepicker with keys #12028
+156
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spingee
changed the title
mudbot
bot
added
accessibility
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
spingee
force-pushed
the
feature/datepicker_key_nav
branch
from
d14ba74 to
88ec782
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances keyboard navigation in the MudDatePicker component by implementing arrow key navigation across different picker views (Date, Month, Year) and enabling Enter key selection. The changes also include focus management improvements and mouse event handling adjustments.
- Implemented arrow key navigation (left/right/up/down) for navigating dates, months, and years
- Enhanced Enter key handling to select the currently highlighted date/month/year based on the current view
- Added FocusAsync() calls when clicking on dates, months, and years for better accessibility
- Modified event handlers to prevent default mouse behavior on certain picker elements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| MudDatePicker.cs | Core logic for keyboard navigation: arrow key handlers for navigating dates/months/years, Enter key selection for highlighted items, and FocusAsync calls in click handlers |
| MudBaseDatePicker.razor.cs | Changed visibility of helper methods/fields from private to protected, updated ScrollToYear to accept optional date parameter, trailing whitespace cleanup |
| MudBaseDatePicker.razor | Added mousedown preventDefault attributes to toolbar and calendar content, cleaned up lambda expressions |
| DatePickerTests.cs | Added comprehensive test for keyboard navigation and date selection workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spingee
force-pushed
the
feature/datepicker_key_nav
branch
from
88ec782 to
d696c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, input now retains focus when popup is clicked