Fix some flake8 warnings

ppigazzini · ppigazzini · commit c522eef6e695 · 2023-10-07T17:19:50.000+02:00
diff --git a/server/fishtest/rundb.py b/server/fishtest/rundb.py
@@ -1,6 +1,5 @@
 import configparser
 import copy
-import gzip
 import io
 import math
 import os
@@ -12,7 +11,6 @@
 import textwrap
 import threading
 import time
-import zlib
 from datetime import datetime, timedelta, timezone
 
 import fishtest.stats.stat_util
@@ -185,7 +183,7 @@ def new_run(
         if spsa is not None:
             run_args["spsa"] = spsa
 
-        tc_base = re.search("^(\d+(\.\d+)?)", tc)
+        tc_base = re.search(r"^(\d+(\.\d+)?)", tc)
         if tc_base:
             tc_base = float(tc_base.group(1))
         new_run = {
diff --git a/server/fishtest/util.py b/server/fishtest/util.py
@@ -503,8 +503,8 @@ def validate(schema, object, name, strict=False):
             return f"{name} is not of type {schema.__name__}"
         else:
             return ""
-    elif isinstance(schema, list) or isinstance(schema, tuple):
-        if type(schema) != type(object):
+    elif isinstance(schema, (list, tuple)):
+        if not isinstance(schema, type(object)):
             return f"{name} is not of type {type(schema).__name}"
         l = len(object)
         if strict and l != len(schema):
@@ -519,7 +519,7 @@ def validate(schema, object, name, strict=False):
                     return ret
         return ""
     elif isinstance(schema, dict):
-        if type(schema) != type(object):
+        if not isinstance(schema, type(object)):
             return f"{name} is not of type {type(schema).__name}"
         if strict:
             _k = _keys(schema)
diff --git a/server/fishtest/views.py b/server/fishtest/views.py
@@ -3,7 +3,6 @@
 import html
 import os
 import re
-import textwrap
 import threading
 import time
 from datetime import datetime, timezone
@@ -21,12 +20,7 @@
     password_strength,
     update_residuals,
 )
-from pyramid.httpexceptions import (
-    HTTPBadRequest,
-    HTTPFound,
-    HTTPUnauthorized,
-    exception_response,
-)
+from pyramid.httpexceptions import HTTPFound, exception_response
 from pyramid.security import forget, remember
 from pyramid.view import forbidden_view_config, view_config
 from requests.exceptions import ConnectionError, HTTPError
@@ -203,7 +197,7 @@ def workers(request):
     ensure_logged_in(request)
     owner_name = worker_name.split("-")[0]
     if not is_approver and blocker_name != owner_name:
-        request.session.flash(f"Only owners and approvers can block/unblock", "error")
+        request.session.flash("Only owners and approvers can block/unblock", "error")
         return {
             "show_admin": False,
             "show_email": is_approver,
diff --git a/server/fishtest/workerdb.py b/server/fishtest/workerdb.py
@@ -1,7 +1,6 @@
 from datetime import datetime, timezone
 
 from fishtest.util import validate
-from pymongo import DESCENDING
 
 schema = {
     "worker_name": str,
