Web-Dev-FT-April2023 | Guglielmo Galasso #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopdg
reviewed
Apr 11, 2023
joaopdg
left a comment
joaopdg
left a comment
There was a problem hiding this comment.
Great job on the lab Guglielmo, next time try to finish all the bonus!
| for (let i=0; i<hacker1.length; i++){ | ||
| variable += hacker1[i]+ " " | ||
| } | ||
| console.log(variable.toUpperCase()) |
There was a problem hiding this comment.
You should use the .toUpperCase() method inside the loop, otherwise you are not saving the string with the upper cased letters, you are just console logging it:
let hacker1Char = "";
for (let i = 0; i<hacker1.length; i++) {
hacker1Char += hacker1[i].toUpperCase() + " ";
}
console.log(hacker1Char)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lab is done