Update TypeWriter Enclosed Action Format#187
Merged
Hyuchia merged 5 commits intoMonogatari:developfrom Jan 13, 2026
Merged
Conversation
Replaces now invalid {/effect} opening tags with correct {effect} syntax in dialog.spec.js.
New: - Exported "tsParticles" for legacy support. Fixes: - Text speed can now be set from the settings slider. - Text speed will now update text-box "typeSpeed" configuration. (Prior, even if you changed the text speed, it wouldn't update until refresh) - "Message" actions will no longer soft lock the screen. - Fixed a bug that caused the "AutoPlaySpeed" to change every time the player modified it and refreshed the game. (Upon refresh, it would always be the opposite of what they chose)
New: - Added a "minTextSpeed" global variable to keep track of the minimum variable speed for later use. - Added the ability to allow semi-instant skipping when the dev has chosen to keep "InstantText" off. (Setting the "min" value on the "text-speed" slider below 0 enables it) - Added a comment to the "stopTyping" function to internally understand what the main differences are when "InstantText" is active and not. Changes: - Changed how text speed was being applied, to keep consistency when reloading the page. Fixes: - Text speed slider bar was occasionally incorrect when refreshing the page. - Fixed an issue where "selector" wasn't being passed to the "init" functions in actions and components.
Fixed a bug that was causing the page to not center correctly when aspect ratio was being enforced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
TypeWritercomponent to improve the parsing and handling of enclosed actions and their options.Action Parsing and Error Handling:
{action}) and closing ({/action}) tags, and added error handling for mismatched or improperly closed actions.Updated Options Parsing:
ParsedAction.optionstype to accept either an object or an array of strings, allowing the use of "empty options" ({size large}Large Text{/size})._parseOptionsmethod to return either an object or an array, depending on the input format, and to split options by whitespace if no key-value pattern is detected.Regex Correction:
QUOTED_VALUE_PATTERNregex to correctly capture quoted values.