Fixing Bugs and Centered Dialog#182
Merged
Hyuchia merged 1 commit intoMonogatari:developfrom Jul 14, 2025
Merged
Conversation
New: - Added a "stopTyping" method, so that the stop typing functionality can be used for any instance of a type-writer. - Added an "ignore" state key that functions as a feature and fix for "string" properties on custom type-writer components and the centered-dialog component. - Added a "goBack" method that functions in the exact same way as the custom function for returning to the main-menu or game-screen. (The reason for this addition was so that the screen return method could be exposed to the developer. This is extremely helpful for developers creating a controller compatible version of their game) Changes: - The "shouldProceed" method inside of the Dialog action now uses the "stopTyping" function. - The "open-screen" listener now uses the "showScreen" function, instead of a custom function, since both "showScreen" and the custom function did the exact same thing. Fixed: - Fixed a bug in in the Dialog action that caused the "centered" speaker to be completely broken. - Fixed an error in the JavaScript linting that was checking for "windows" when it should have been checking for "unix". - Fixed a bug that was causing "instance" custom actions to not function properly. - Fixed the "delay" property when creating a custom type-writer component. - Fixed a grammatical error in two comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is mainly to fix the "centered-dialog" component, but I also made a couple other changes/fixes as well.
New:
Changes:
Fixed: