Skip to content

Fixing Bugs and Centered Dialog#182

Merged
Hyuchia merged 1 commit intoMonogatari:developfrom
MidZM:develop
Jul 14, 2025
Merged

Fixing Bugs and Centered Dialog#182
Hyuchia merged 1 commit intoMonogatari:developfrom
MidZM:develop

Conversation

@MidZM
Copy link
Contributor

@MidZM MidZM commented Jun 10, 2025

This pull request is mainly to fix the "centered-dialog" component, but I also made a couple other changes/fixes as well.

New:

  • Added a "stopTyping" method so that the stop typing functionality can be used for any instance of a type-writer.
  • Added an "ignore" state key that functions as a feature and fix for "string" properties on custom type-writer components and the centered-dialog component.
  • Added a "goBack" method that functions in the exact same way as the custom function for returning to the main-menu or game-screen. (The reason for this addition was so that the screen return method could be exposed to the developer. This is extremely helpful for developers creating a controller compatible version of their game)

Changes:

  • The "shouldProceed" method inside of the Dialog action now uses the "stopTyping" function.
  • The "open-screen" listener now uses the "showScreen" function, instead of a custom function, since both "showScreen" and the custom function did the exact same thing.

Fixed:

  • Fixed a bug in the Dialog action that caused the "centered" speaker to be completely broken.
  • Fixed an error in the JavaScript linting that was checking for "windows" when it should have been checking for "unix".
  • Fixed a bug that was causing "instance" custom actions to not function properly.
  • Fixed the "delay" property when creating a custom type-writer component.
  • Fixed a grammatical error in two comments.

New:
- Added a "stopTyping" method, so that the stop typing functionality can be used for any instance of a type-writer.
- Added an "ignore" state key that functions as a feature and fix for "string" properties on custom type-writer components and the centered-dialog component.
- Added a "goBack" method that functions in the exact same way as the custom function for returning to the main-menu or game-screen. (The reason for this addition was so that the screen return method could be exposed to the developer. This is extremely helpful for developers creating a controller compatible version of their game)

Changes:
- The "shouldProceed" method inside of the Dialog action now uses the "stopTyping" function.
- The "open-screen" listener now uses the "showScreen" function, instead of a custom function, since both "showScreen" and the custom function did the exact same thing.

Fixed:
- Fixed a bug in in the Dialog action that caused the "centered" speaker to be completely broken.
- Fixed an error in the JavaScript linting that was checking for "windows" when it should have been checking for "unix".
- Fixed a bug that was causing "instance" custom actions to not function properly.
- Fixed the "delay" property when creating a custom type-writer component.
- Fixed a grammatical error in two comments.
@Hyuchia Hyuchia merged commit 670e0a9 into Monogatari:develop Jul 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants