Skip to content

Add check for M1 Pro/Max Macbook Pro HDMI #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the0neyouseek merged 1 commit into from
Jan 22, 2022
Merged

Add check for M1 Pro/Max Macbook Pro HDMI #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions MonitorControl/Support/Arm64DDC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,13 @@ class Arm64DDC: NSObject {
if let modelData = IORegistryEntryCreateCFProperty(platformExpertDevice, "model" as CFString, kCFAllocatorDefault, 0).takeRetainedValue() as? Data, let modelIdentifierCString = String(data: modelData, encoding: .utf8)?.cString(using: .utf8) {
modelIdentifier = String(cString: modelIdentifierCString)
}
// First service location of Mac Mini HDMI is broken for DDC communication
if ioregService.transportDownstream == "HDMI", ioregService.serviceLocation == 1, modelIdentifier == "Macmini9,1" {
// First service location of M1 Mac Mini & Macbook Pro HDMI is broken for DDC communication
let ddcBlockedModels = [
"Macmini9", // Mac mini M1 2020
"MacBookPro18", // Macbook Pro M1 Pro/Max 2021 (14", 16")
]
let isBlockedModel = ddcBlockedModels.contains { $0.starts(with: modelIdentifier) }
if ioregService.transportDownstream == "HDMI", ioregService.serviceLocation == 1, isBlockedModel {
return true
}
return false
Expand Down