Skip to content

Conversation

@waydabber
Copy link
Member

@waydabber waydabber commented Sep 1, 2021

Bug fixes / enhancements in this pull request:

  • Fixed not working after sleep mode for some on Apple Silicon Not working after sleep mode #530
  • Fixed some LG and Samsung displays having problems with Mute (improved 'Enable Mute DDC command') - LG Monitor: have to unmute manually after muting #170
  • Fixed app not working with multiple identical monitors on Intel - App does not work with multiple identical monitors #49
  • Added 'Safe Mode' option - pressing the Shift key during startup resets preferences and disables DDC read.
  • Upon first start if DDC is unreadable, default brightness/volume/contrast values are now set to a sensible 75% instead of 0%
  • DDC write commands are issued twice on Intel (as it already was on Arm64) to improve stability on some setups.
  • Make sure DDC communications don't happen in parallel when both slider menu and keyboard is used (this might have caused problems with some docks with multiple display outputs).
  • Fixed volume control feedback audio (clicking sound) during key repeat (it should play on keyup only as this is the macOS standard).
  • Fixed duplication of volume control feedback audio if there are multiple external displays and 'Change... for all screens' is enabled.
  • Internal DDC library for Intel (based on the work of reitermarkus)

Please, do a general testing on Intel if possible to make sure everything works. On M1 everything seems all right.

… is no registered display configuration change (this to prevent some sleep issues on Apple Silicon).
…dard for write operations (should not hurt but improve stability for problematic displays).
… default value instead of 0 if it is not available and could not read DDC.
Copy link
Member

@JoniVR JoniVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially having an issue where, when muting, the monitor OSD and MacOS would display as muted state but volume level would still be at level 6 (even though the display OSD indicated muted), this is probably not a big deal and now I'm unable to reproduce it, but I guess we might get some issues opened for this if it does happen for other people.

edit:
Here it is (had to compress quite a bit to get it allowed on Github):

ezgif com-gif-maker (1)

This might be a part of the fix, and it seems to work fine, I haven't read up on the entire issue thread, so it's fine for me personally. Only happens when "Enable Mute DDC Command" is enabled, so seems like a feature :)

@JoniVR
Copy link
Member

JoniVR commented Sep 1, 2021

Regarding the reliability issue on optimised builds, that still seems to be present, it's about the same level now as my earlier "hacky fix" was (which was basically also sending the command twice). On unoptimised builds it looks to be perfectly reliable.

As a side note, the idea of a safe mode and the way you've implemented it is great! As are all the other fixes of course! Nice work!

@waydabber
Copy link
Member Author

This might be a part of the fix, and it seems to work fine, I haven't read up on the entire issue thread, so it's fine for me personally. Only happens when "Enable Mute DDC Command" is enabled, so seems like a feature :)

Yes, this is a feature actually. When Mute DDC Command is enabled, the app will never issue Volume=0 since that makes some displays do bad things, it only issues a Mute instead while internally remembering that the volume is logically 0. This is how it worked for the guys who were testing this for me after several attempts.

Copy link
Member

@JoniVR JoniVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@waydabber waydabber merged commit 30ac465 into master Sep 1, 2021
@JoniVR
Copy link
Member

JoniVR commented Sep 1, 2021

Want me to do RC2 btw?

@JoniVR JoniVR deleted the temp/debug branch September 1, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not working after sleep mode LG Monitor: have to unmute manually after muting App does not work with multiple identical monitors

2 participants