-
Notifications
You must be signed in to change notification settings - Fork 929
3.0.0 bug fixes and some enhancements #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…umber to acquire framebuffer port on Intel
… is no registered display configuration change (this to prevent some sleep issues on Apple Silicon).
…dard for write operations (should not hurt but improve stability for problematic displays).
… preferences and disable DDC read.
… default value instead of 0 if it is not available and could not read DDC.
…peats or first keydown)
…ring. Alternate fix for M1 sleep issue.
…e involved in volume change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially having an issue where, when muting, the monitor OSD and MacOS would display as muted state but volume level would still be at level 6 (even though the display OSD indicated muted), this is probably not a big deal and now I'm unable to reproduce it, but I guess we might get some issues opened for this if it does happen for other people.
edit:
Here it is (had to compress quite a bit to get it allowed on Github):
This might be a part of the fix, and it seems to work fine, I haven't read up on the entire issue thread, so it's fine for me personally. Only happens when "Enable Mute DDC Command" is enabled, so seems like a feature :)
|
Regarding the reliability issue on optimised builds, that still seems to be present, it's about the same level now as my earlier "hacky fix" was (which was basically also sending the command twice). On unoptimised builds it looks to be perfectly reliable. As a side note, the idea of a safe mode and the way you've implemented it is great! As are all the other fixes of course! Nice work! |
Yes, this is a feature actually. When Mute DDC Command is enabled, the app will never issue Volume=0 since that makes some displays do bad things, it only issues a Mute instead while internally remembering that the volume is logically 0. This is how it worked for the guys who were testing this for me after several attempts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀 🚀
|
Want me to do RC2 btw? |

Bug fixes / enhancements in this pull request:
Please, do a general testing on Intel if possible to make sure everything works. On M1 everything seems all right.