Add "Standard keys (force capture)" option to volume control dropdown#1846
Open
shuntagami wants to merge 4 commits intoMonitorControl:mainfrom
Open
Add "Standard keys (force capture)" option to volume control dropdown#1846shuntagami wants to merge 4 commits intoMonitorControl:mainfrom
shuntagami wants to merge 4 commits intoMonitorControl:mainfrom
Conversation
Keep the current safety behavior by default, but allow advanced users to force-capture standard volume media keys even when macOS output volume is controllable. Made-with: Cursor
Expose an explicit UI switch for force-capturing standard volume keys so advanced users can opt in without using hidden defaults commands. Made-with: Cursor
Keep the new volume-key override toggle visible in Keyboard settings while preserving the opt-in behavior for advanced users. Made-with: Cursor
Author
|
@waydabber Review plz! |
…heckbox Replace the separate "Force capture standard volume and mute keys" checkbox with a new "Standard keys (force capture)" option in the existing Volume control dropdown (KeyboardVolume.mediaForce, tag=4). This integrates the feature more naturally into the existing UI, avoids removing the helpful "audio device name override" hint text, and eliminates the forceStandardVolumeMediaKeys preference key in favor of the enum-based approach. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shuntagami
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyboardVolume.mediaForceenum case (tag=4) as a "Standard keys (force capture)" option in the existing Volume control dropdownTest plan
Screen Shot
🤖 Generated with Claude Code