Use absolute paths for system framework references#1012
Merged
waydabber merged 1 commit intoMonitorControl:mainfrom May 6, 2022
DimitarNestorov:absolute-system-framework-paths
Merged
Use absolute paths for system framework references#1012waydabber merged 1 commit intoMonitorControl:mainfrom DimitarNestorov:absolute-system-framework-paths
waydabber merged 1 commit intoMonitorControl:mainfrom
DimitarNestorov:absolute-system-framework-paths
Conversation
Contributor
Author
|
Not sure what's up with CI. Tried running with my changes reverted but it's still failing: https://github.com/dimitarnestorov/MonitorControl/runs/6112268134?check_suite_focus=true |
Member
|
@DimitarNestorov It seems to be an issue with the KeyboardShortcuts package, not your changes |
Member
|
Also SimplyCoreAudio. I think there might be some changes here that somehow adversely affects packages. @DimitarNestorov - how should we proceed with this? |
Member
|
Ok, disragard that. It seems everything fails now with the CI build as the other PR got stuck with the exact same issue #1025 |
waydabber
approved these changes
May 6, 2022
Member
waydabber
left a comment
waydabber
left a comment
There was a problem hiding this comment.
All right, I'll approve this one as the changes are entirely sensible, I don't know whats up with the CI build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to improve developer experience. If you clone MonitorControl in a deep enough folder (e.g.
/tmp/1/2/3/4/5/6/7) those frameworks will appear as if they are missing.