Replies: 1 comment
-
|
This setting does not disable Sparkle in general, it just tells it not to inform the users about updates I think. But really this is a general Sparkle issue, I think you should report this there (why does it try to connect if it is set not to do)? But the issue might already be fixed in the latest Sparkle versions, not sure. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Before opening the issue, have you...?
Describe the bug
When the "Automatically check for updates" checkbox is unchecked in Preferences > General, MonitorControl continues to make network requests to monitorcontrol.app, github.com, and githubusercontent.com. Network monitoring software (firewall/network control tools) still shows these connection attempts despite the preference being disabled.
Steps to reproduce
Expected behavior
When "Automatically check for updates" is unchecked, the app should not make any network requests or initialize the Sparkle updater framework. Network activity should only occur when manually clicking "Check for updates" in the About preferences.
Anything else?
Root cause: AppDelegate.swift line 68 unconditionally calls
updaterController.startUpdater()regardless of the SUEnableAutomaticChecks preference setting. The checkbox only sets the
preference but doesn't prevent the updater from initializing and making network requests.
Suggested fix: Wrap line 68 in a conditional check:
if prefs.bool(forKey: PrefKey.SUEnableAutomaticChecks.rawValue) {
self.updaterController.startUpdater()
}
Environment Information (please complete the following information)
Beta Was this translation helpful? Give feedback.
All reactions