Issue 68 allow additional custom mongo db arguments#69
Merged
JohannesHoppe merged 7 commits intoMay 10, 2019
Merged
Conversation
make sure any additional argument passed in does not clash with already defined, by Mongo2Go, mongod arguments.
…god arguments as parameter
JohannesHoppe
requested changes
Mar 18, 2019
Member
JohannesHoppe
left a comment
JohannesHoppe
left a comment
There was a problem hiding this comment.
Thank you so much, this looks like solid work.
…dy defined by Mongo2Go, throw ArgumentException
…hrown after all additional arguments are verified
…exception message is also verified
Contributor
Author
|
Changes made, CR comments addressed, but Travis CI is not playing along: build passing, but github not notified... @JohannesHoppe any insights on this? |
Member
|
I just started another build. Hopefully I can review, merge and publish your PR in the beginning of next week! |
Member
|
Thanks for the patience, v2.2.11 is right now building/deploying on AppVeyor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add parameter to process start and MongoDb runner to allow passing in additional mongod parameters