Skip to content

Single node replica set option to enable transactions#57

Merged
JohannesHoppe merged 12 commits into
Mongo2Go:masterfrom
mahisatyanarayana:master
Oct 12, 2018
Merged

Single node replica set option to enable transactions#57
JohannesHoppe merged 12 commits into
Mongo2Go:masterfrom
mahisatyanarayana:master

Conversation

@mahisatyanarayana
Copy link
Copy Markdown

Added option to spin up mongod as a single node replica set so transactions could be enabled.

Mahi Satyanarayana added 8 commits September 19, 2018 17:25
…rorOutput are assigned correctly

2. Connecting to the server to initiate the replicaSet
…we need to connect to the primary in order to initiate the repl set

1. Updated the drivers to 2.7.0 (why didn't I do this two days ago?)
2. If mongo2go is started with  singleNodeReplSet flag equals to true then the MongoDbProcessStarter will spin up and INITIATE a replica set
3. All tests are passing at this moment
…lica set

2. Use the port variable to build replica set config
3. Update nuspec with pre-release tag for local testing
4. Update README.md with correct binary version
2. Set readPreference to "primary" in the uri while connecting to a replica set
3. Sleep the thread for 5 seconds right after sending replSetInitiate command so replica set has time to finish initiating
@JohannesHoppe
Copy link
Copy Markdown
Member

JohannesHoppe commented Sep 26, 2018

This looks like some excellent work. Could you please document this feature?
E.g. a new part in the README with a short introduction and a sample, how to leverage transactions?

@mahisatyanarayana
Copy link
Copy Markdown
Author

I will update the README document. Thank you!

@mahisatyanarayana
Copy link
Copy Markdown
Author

mahisatyanarayana commented Sep 27, 2018

@JohannesHoppe - I have updated the README. Please let me know if you have any questions, comments or concerns.

P.S. Also took the liberty to modify the changelog section. Please feel free to update/modify it.

Thank you,
Mahi

@JohannesHoppe
Copy link
Copy Markdown
Member

This is how a PR should look like. I will review everything early next week.

@mahisatyanarayana
Copy link
Copy Markdown
Author

Hey @JohannesHoppe - Just following up to see if you had a chance to look at the pr.

Thank you,
Mahi

@fauxcoding
Copy link
Copy Markdown

Nice work @gbackmania. Its a great feeling looking for a feature in an OSS library and finding a PR delivering it!

@JohannesHoppe JohannesHoppe merged commit 1293068 into Mongo2Go:master Oct 12, 2018
@JohannesHoppe
Copy link
Copy Markdown
Member

v2.2.8 is out, many thanks! 👍

@mahisatyanarayana
Copy link
Copy Markdown
Author

Thank you @JohannesHoppe. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants