Skip to content

Commit 8beeff2

Browse files
manucorporatbrandyscarney
manucorporat
authored and
brandyscarney
committed
fix(virtual-scroll): remove runOutsideAngular error (ionic-team#18752)
fixes ionic-team#18746
1 parent f060db5 commit 8beeff2

15 files changed

Lines changed: 38 additions & 26 deletions

‎angular/src/directives/virtual-scroll/virtual-scroll.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export class IonVirtualScroll {
128128
@ContentChild(VirtualFooter) ftrTmp!: VirtualFooter;
129129

130130
constructor(
131-
private zone: NgZone,
131+
private z: NgZone,
132132
private iterableDiffers: IterableDiffers,
133133
elementRef: ElementRef,
134134
) {
@@ -162,7 +162,7 @@ export class IonVirtualScroll {
162162
}
163163

164164
private nodeRender(el: HTMLElement | null, cell: Cell, index: number): HTMLElement {
165-
return this.zone.run(() => {
165+
return this.z.run(() => {
166166
let node: EmbeddedViewRef<VirtualContext>;
167167
if (!el) {
168168
node = this.itmTmp.viewContainer.createEmbeddedView(

‎angular/test/test-app/e2e/protractor.conf.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ exports.config = {
1010
],
1111
capabilities: {
1212
browserName: 'chrome',
13-
13+
1414
chromeOptions: {
1515
args: [ "--headless", "--disable-gpu", "--window-size=400,1000", "--start-maximized" ]
1616
}

‎angular/test/test-app/e2e/src/form.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { handleErrorMessages, setProperty, getText, waitTime } from './utils';
44
describe('form', () => {
55

66
afterEach(() => {
7-
handleErrorMessages();
7+
return handleErrorMessages();
88
});
99

1010
describe('change', () => {

‎angular/test/test-app/e2e/src/inputs.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('inputs', () => {
88
await waitTime(30);
99
});
1010
afterEach(() => {
11-
handleErrorMessages();
11+
return handleErrorMessages();
1212
});
1313

1414
it('should have default value', async () => {

‎angular/test/test-app/e2e/src/modal.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('modals', () => {
88
await waitTime(30);
99
});
1010
afterEach(() => {
11-
handleErrorMessages();
11+
return handleErrorMessages();
1212
});
1313

1414
it('should open standalone modal and close', async () => {

‎angular/test/test-app/e2e/src/navigation.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { handleErrorMessages, waitTime, testStack } from './utils';
44
describe('navigation', () => {
55

66
afterEach(() => {
7-
handleErrorMessages();
7+
return handleErrorMessages();
88
});
99

1010
it('should navigate correctly', async () => {

‎angular/test/test-app/e2e/src/nested-outlet.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { waitTime, handleErrorMessages, goBack } from './utils';
44
describe('nested-outlet', () => {
55

66
afterEach(() => {
7-
handleErrorMessages();
7+
return handleErrorMessages();
88
});
99

1010
it('should navigate correctly', async () => {

‎angular/test/test-app/e2e/src/providers.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { handleErrorMessages, waitTime } from './utils';
44
describe('providers', () => {
55

66
afterEach(() => {
7-
handleErrorMessages();
7+
return handleErrorMessages();
88
});
99

1010
it('should load all providers', async () => {

‎angular/test/test-app/e2e/src/router-link.e2e-spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('router-link params and fragments', () => {
99
const id = 'MyPageID==';
1010

1111
afterEach(() => {
12-
handleErrorMessages();
12+
return handleErrorMessages();
1313
});
1414

1515
it('should go to a page with properly encoded values', async () => {
@@ -53,7 +53,7 @@ describe('router-link', () => {
5353
await waitTime(30);
5454
});
5555
afterEach(() => {
56-
handleErrorMessages();
56+
return handleErrorMessages();
5757
});
5858

5959

‎angular/test/test-app/e2e/src/slides.e2e-spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('slides', () => {
88
await waitTime(30);
99
});
1010
afterEach(() => {
11-
handleErrorMessages();
11+
return handleErrorMessages();
1212
});
1313

1414
it('should change index on slide change', async () => {

0 commit comments

Comments
 (0)