Merged
Conversation
ghost
mentioned this pull request
zloeber
approved these changes
Oct 24, 2017
Collaborator
|
Great catch, I wasn't testing new projects in folders with spaces. Thanks much for fixing! |
ghost
deleted the
fix-initialize-modulebuild-error
branch
October 28, 2017 21:52
Author
|
Hi @zloeber, Thanks. |
Collaborator
|
Sure, that's a fair enough request. I'll push it up shortly. |
Author
|
Thanks! |
zloeber
pushed a commit
that referenced
this pull request
Jan 16, 2019
LoadBuildTools on InstallAndTestModule for Get-SpecialPaths function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix #1 and #2 .
About issue 2, the errors is fired if spaces are present in the path of the project root directory. Now script path is enclosed in ''.