Add support for batch size parameter#16
Merged
Pringled merged 1 commit intoMinishLab:mainfrom Jan 15, 2025
Merged
Conversation
Add batch size parameter to enhance encoding flexibility - Introduced `--batch-size` argument to the parser to allow users to specify the batch size during encoding. - Improved script flexibility for diverse hardware configurations by enabling user-defined batch sizes.
Pringled
approved these changes
Jan 15, 2025
Member
Pringled
left a comment
Pringled
left a comment
There was a problem hiding this comment.
Hey @andreim14, thanks for creating this PR! LGTM, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
--batch-sizeparameter to the script, allowing users to control the number of texts processed in each batch during encoding.Changes:
--batch-sizeargument to the featurize.py script.Benefits:
Testing:
Please review and let me know if further adjustments are needed!