Automatic ruff check improvements (official-stockfish#345)

Disservin · web-flow · commit e6b9f54946b9 · 2025-09-21T17:16:26.000+02:00
diff --git a/delete_bad_nets.py b/delete_bad_nets.py
@@ -59,9 +59,9 @@ def get_nets_by_directory(best_nets, worst_nets, num_best_to_keep=16):
 
     for net_name, rating, error in itertools.chain(best_nets, worst_nets):
         basedir = get_net_dir(net_name)
-        if not basedir in binned_best_nets:
+        if basedir not in binned_best_nets:
             binned_best_nets[basedir] = []
-        if not basedir in binned_worst_nets:
+        if basedir not in binned_worst_nets:
             binned_worst_nets[basedir] = []
 
     for net_name, rating, error in worst_nets:
diff --git a/do_plots.py b/do_plots.py
@@ -191,7 +191,7 @@ def do_plots(out_filename, root_dirs, elo_range, loss_range, split):
                     epoch = row[1]
                     elo = row[2]
                     error = row[3]
-                    if not epoch in epochs:
+                    if epoch not in epochs:
                         if elo > maxelo - elo_range:
                             epochs.append(epoch)
                             elos.append(elo)
diff --git a/perf_sigmoid_fitter.py b/perf_sigmoid_fitter.py
@@ -4,7 +4,6 @@
 import sys
 import data_loader
 import torch
-import sys
 
 
 def sigmoid(x, k):
diff --git a/run_games.py b/run_games.py
@@ -50,12 +50,12 @@ def get_all_params(self):
         params += [
             f"option.Hash={self.hash}",
             f"option.Threads={self.threads}",
-            f"timeout=20",
+            "timeout=20",
         ]
 
         if self.nodes_per_move:
             params += [
-                f"tc=10000+10000",
+                "tc=10000+10000",
                 f"nodes={self.nodes_per_move}",
             ]
         else:
diff --git a/scripts/easy_train.py b/scripts/easy_train.py
@@ -1,7 +1,6 @@
 #!/usr/bin/env python3
 
 import time
-import random
 import sys
 import psutil
 import re
@@ -11,7 +10,6 @@
 import argparse
 import math
 import logging
-import time
 
 EXITCODE_OK = 0
 EXITCODE_MISSING_DEPENDENCIES = 2
@@ -184,11 +182,11 @@ def validate_pytorch():
             from torch import cuda
 
             if cuda.is_available() and cuda.device_count() > 0:
-                LOGGER.info(f"Found torch with CUDA. OK.")
+                LOGGER.info("Found torch with CUDA. OK.")
                 return True
             else:
                 LOGGER.error(
-                    f"Found torch without CUDA but CUDA support required. Exiting"
+                    "Found torch without CUDA but CUDA support required. Exiting"
                 )
                 return False
         else:
@@ -269,10 +267,8 @@ def validate_environment_requirements():
 # Only now import the rest of the required packages
 from asciimatics.widgets import (
     Frame,
-    ListBox,
     Layout,
     Divider,
-    Text,
     Button,
     TextBox,
     Widget,
@@ -283,10 +279,8 @@ def validate_environment_requirements():
 )
 from asciimatics.scene import Scene
 from asciimatics.screen import Screen
-from asciimatics.exceptions import ResizeScreenError, NextScene, StopApplication
-from asciimatics.utilities import BoxTool
-from asciimatics.constants import SINGLE_LINE, DOUBLE_LINE
-from asciimatics.event import KeyboardEvent, MouseEvent
+from asciimatics.exceptions import ResizeScreenError, StopApplication
+from asciimatics.event import KeyboardEvent
 from threading import Thread, Lock, Event
 import GPUtil
 import io
@@ -296,8 +290,6 @@ def validate_environment_requirements():
 import shutil
 import urllib.request
 import urllib.parse
-import signal
-from datetime import datetime, timedelta
 from tqdm.auto import tqdm
 from pathlib import Path
 
@@ -356,7 +348,7 @@ def terminate_process_on_exit(process):
 def schedule_exit(timeout_seconds, errcode):
     def f():
         time.sleep(timeout_seconds)
-        LOGGER.info(f"Performing a scheduled exit.")
+        LOGGER.info("Performing a scheduled exit.")
         if TUI_SCREEN:
             if sys.platform == "win32":
                 TUI_SCREEN.close(restore=True)
@@ -1046,7 +1038,7 @@ def requests_get_content(url, *args, **kwargs):
         result = requests.get(url, *args, **kwargs)
         result.raise_for_status()
         return result.content
-    except Exception as e:
+    except Exception:
         raise Exception(f"GET request to {url} failed")
 
 
@@ -1250,7 +1242,7 @@ def setup_nnue_pytorch(directory, repo, branch_or_commit):
             )
 
     if not is_nnue_pytorch_setup(directory):
-        raise Exception(f"Incorrect nnue-pytorch setup or timeout.")
+        raise Exception("Incorrect nnue-pytorch setup or timeout.")
 
 
 class CChessCliRunningTestEntry:
@@ -1429,7 +1421,7 @@ def get_status_string(self):
                 return "\n".join(lines)
             elif self._current_convert is not None:
                 lines = [
-                    f"Converting network...",
+                    "Converting network...",
                     f"Run  : {self._current_convert[0]}",
                     f"Epoch: {self._current_convert[1]}",
                 ]
@@ -2667,7 +2659,7 @@ def main():
 
     # Global (workspace) setup
 
-    with SystemWideMutex(os.path.join(absolute_workspace_path, f".lock")) as mutex:
+    with SystemWideMutex(os.path.join(absolute_workspace_path, ".lock")) as mutex:
         ordo_directory = os.path.join(absolute_workspace_path, "ordo")
         c_chess_cli_directory = os.path.join(absolute_workspace_path, "c-chess-cli")
         books_directory = os.path.join(absolute_workspace_path, "books")
@@ -2687,13 +2679,13 @@ def main():
     )
     try:
         os.makedirs(experiment_directory, exist_ok=False)
-    except FileExistsError as e:
+    except FileExistsError:
         if args.fail_on_experiment_exists and os.listdir(experiment_directory):
             LOGGER.error(
                 f"Directory {experiment_directory} already exists. An experiment must use a new directory."
             )
             LOGGER.error(
-                f"Alternatively, override this with the option --resume-training=True or --fail-on-experiment-exists=False."
+                "Alternatively, override this with the option --resume-training=True or --fail-on-experiment-exists=False."
             )
             return
 

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,12 @@ def get_all_params(self):`
`50`	`50`	`params += [`
`51`	`51`	`f"option.Hash={self.hash}",`
`52`	`52`	`f"option.Threads={self.threads}",`
`53`		`- f"timeout=20",`
	`53`	`+ "timeout=20",`
`54`	`54`	`]`
`55`	`55`
`56`	`56`	`if self.nodes_per_move:`
`57`	`57`	`params += [`
`58`		`- f"tc=10000+10000",`
	`58`	`+ "tc=10000+10000",`
`59`	`59`	`f"nodes={self.nodes_per_move}",`
`60`	`60`	`]`
`61`	`61`	`else:`