Skip to content

Make code compile, function and actually follow the EABI - #941

Merged
Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
pmsjt:patch-8
Apr 12, 2019
Merged

Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
pmsjt:patch-8

Conversation

@pmsjt

Copy link
Copy Markdown
Contributor

Also fix alignment issues in the EABI portion itself. In ARM64, SP is always kept with 16 byte alignment. Examples with -72 offsets or the compact format itself spec, which mentioned 4088 were trivially incorrect.

Fix syntax errors, negative/positive errors, register names errors as well.

All provided canonical code now compiles, functions and follows the EABI.

Also fix alignment issues in the EABI portion itself. In ARM64, SP is always kept with 16 byte alignment. Examples with -72 offsets or the compact format itself spec, which mentioned 4088 were trivially incorrect.

Fix syntax errors, negative/positive errors, register names errors as well.

All provided canonical code now compiles, functions and follows the EABI.
@PRMerger20

Copy link
Copy Markdown
Contributor

Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Comment thread docs/build/arm64-exception-handling.md Outdated
ldp d10,d11,[sp,#64]
...
ldp r29, lr, [sp], -80 // post-indexed, reload <r29,lr>
ldp x29,lr,[sp],80 // post-indexed, reload <x29,lr>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#80?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll fix this right away.

@PRMerger8

Copy link
Copy Markdown
Contributor

Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@ThomsonTan Tom Tan (ThomsonTan) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@colin-home
Colin Robertson (colin-home) merged commit 88f23bf into MicrosoftDocs:master Apr 12, 2019
@pmsjt
Pedro Miguel Justo (pmsjt) deleted the patch-8 branch June 21, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants