Repository navigation
Make code compile, function and actually follow the EABI - #941
Merged
Colin Robertson (colin-home) merged 2 commits intoApr 12, 2019
Merged
Conversation
Also fix alignment issues in the EABI portion itself. In ARM64, SP is always kept with 16 byte alignment. Examples with -72 offsets or the compact format itself spec, which mentioned 4088 were trivially incorrect. Fix syntax errors, negative/positive errors, register names errors as well. All provided canonical code now compiles, functions and follows the EABI.
Contributor
|
Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
| ldp d10,d11,[sp,#64] | ||
| ... | ||
| ldp r29, lr, [sp], -80 // post-indexed, reload <r29,lr> | ||
| ldp x29,lr,[sp],80 // post-indexed, reload <x29,lr> |
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll fix this right away.
Contributor
|
Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
Colin Robertson (colin-home)
approved these changes
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix alignment issues in the EABI portion itself. In ARM64, SP is always kept with 16 byte alignment. Examples with -72 offsets or the compact format itself spec, which mentioned 4088 were trivially incorrect.
Fix syntax errors, negative/positive errors, register names errors as well.
All provided canonical code now compiles, functions and follows the EABI.