Skip to content

Clarify naming confusion "_mul128" vs. "__mul128" - #887

Merged
Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
CaseyCarter:patch-3
Mar 27, 2019
Merged

Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
CaseyCarter:patch-3

Conversation

@CaseyCarter

Copy link
Copy Markdown
Contributor

The proper name is _mul128.

Verified with VS2019 Preview 4.4 that __mul128 is not recognized as an intrinsic even if properly declared and #pragma intrinsic-ed.

@PRMerger12

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Update date, some formatting.
@PRMerger13

Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casey Carter (@CaseyCarter) Thanks, looks good.

@colin-home
Colin Robertson (colin-home) merged commit 7e71886 into MicrosoftDocs:master Mar 27, 2019
@CaseyCarter

Copy link
Copy Markdown
Contributor Author

Casey Carter (@CaseyCarter) : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@corob-msft Who do we complain to about this broken PR bot message?

@colin-home

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) That's a good question. Some of the PR bots get it right; this one doesn't, and I'm guessing it's because we have the author metadata field populated by folder in docfx.json instead of inside every article. Much easier to update in bulk that way, but harder to discover just by inspection of a file of interest. Let me ask around.

@meganbradley

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) @corob-msft - thanks, I've added this to the backlog for GitHub automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants