Repository navigation
__chkstk parameter register correction (x8 -> x15) - #875
Closed
Pedro Miguel Justo (pmsjt) wants to merge 1 commit into
Closed
Pedro Miguel Justo (pmsjt) wants to merge 1 commit into
Pedro Miguel Justo (pmsjt) wants to merge 1 commit into
Conversation
In "Stack", this document indicates that the parameter to __chkstk should be passed via x8. This is incorrect. It is really passed via x15.
Contributor
|
Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
Colin Robertson (colin-home)
left a comment
Contributor
There was a problem hiding this comment.
Pedro Miguel Justo (@pmsjt) Thanks for jumping on this; I should have said I already fixed it in #872, and the change is live now.
Contributor
|
Closing, fixed in changes merged in #877. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "Stack", this document indicates that the parameter to __chkstk should be passed via x8. This is incorrect. It is really passed via x15.