Skip to content

Update popcnt16-popcnt-popcnt64.md - #793

Merged
Mike B (mikeblome) merged 2 commits into
MicrosoftDocs:masterfrom
CaseyCarter:patch-3
Feb 11, 2019
Merged

Mike B (mikeblome) merged 2 commits into
MicrosoftDocs:masterfrom
CaseyCarter:patch-3

Conversation

@CaseyCarter

Copy link
Copy Markdown
Contributor
  • "16-, 32-, or 64-byte" is an obvious typo.
  • "The size of the value that the popcnt instruction returns is the same as the size of its argument." is a clear case of "parameter" vs. "argument" confusion. The size / type of the return value does not change to reflect the size/type of the expression passed to the function at a callsite - this sentence means "parameter." (Although honestly, this sentence adds little value - we should consider striking it.)

* "16-, 32-, or 64-byte" is an obvious typo.
* "The size of the value that the `popcnt` instruction returns is the same as the size of its argument." is a clear case of "parameter" vs. "argument" confusion. The size / type of the return value does not change to reflect the size/type of the expression passed to the function at a callsite - this sentence means "parameter." (Although honestly, this sentence adds little value - we should consider striking it.)
@PRMerger17

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@mikeblome Mike B (mikeblome) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Casey Carter (@CaseyCarter)! I went ahead and deleted the sentence.

@mikeblome

Copy link
Copy Markdown
Contributor

#sign-off

@PRMerger9

Copy link
Copy Markdown
Contributor

Mike B (@mikeblome): I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@mikeblome
Mike B (mikeblome) merged commit 0235b97 into MicrosoftDocs:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants