Wrong Error Specified in unlink/remove#722
Merged
colin-home merged 1 commit intoMicrosoftDocs:masterfrom Jan 18, 2019
Merged
Conversation
_unlink, _wulink, _remove, and _wremove actually give EACCES if used on a directory, no ENOENT.
Contributor
|
@jmittert : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
colin-home
approved these changes
Jan 18, 2019
Contributor
colin-home
left a comment
There was a problem hiding this comment.
@jmittert I love PRs with supporting evidence attached. Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_unlink, _wulink, _remove, and _wremove in the docs all specify that if used on a directory, they set errno "to ENOENT, which means the file or path is not found or the path specified a directory."
However, actually using them on a directory gives EACCES, which makes sense given that they all seem to call through to DeleteFileW which gives ERROR_ACCESS_DENIED when used on a directory.
This can be reproduced using something like