Closed
Conversation
Contributor
|
@nschonni : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
mikeblome
suggested changes
Nov 7, 2018
Contributor
mikeblome
left a comment
mikeblome
left a comment
There was a problem hiding this comment.
@nschonni Thanks for the PR and for finding these .suo and .pfx file that should not be in the repo. Deleting those files is good. But I'm asking to NOT change the gitignore because we never expect these file types to get checked into a docs repo. Those two examples were the only ones out of hundreds of code snippets. If this ever becomes a problem in the future, of course we can revisit this and perhaps update the file.
Contributor
Author
|
No problem, feel free to fix internally |
Contributor
|
ok will do thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if the
pfxfile should get added back, but the rest are local user files