Skip to content

MASM: Add PROC as another possible type for EXTERN#5139

Merged
TylerMSFT merged 1 commit into
MicrosoftDocs:mainfrom
nir9:patch-4
Dec 9, 2024
Merged

MASM: Add PROC as another possible type for EXTERN#5139
TylerMSFT merged 1 commit into
MicrosoftDocs:mainfrom
nir9:patch-4

Conversation

@nir9

@nir9 nir9 commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Problem: Current documentation for EXTERN misses an important possible type which is PROC.
This type is important since it enables calling external procedures, for instance, the following
is an example of calling Sleep from kernel32 (assuming the kernel32.lib is specified during linkage):

public main
extern Sleep : PROC

.CODE

main:
mov rcx, 1000
call Sleep
ret

END

@prmerger-automator

prmerger-automator Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@nir9 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

learn-build-service-prod Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit be434a3:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/extern-masm.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72

Court72 commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Dec 9, 2024
TylerMSFT
TylerMSFT approved these changes Dec 9, 2024
View reviewed changes

@TylerMSFT TylerMSFT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@TylerMSFT TylerMSFT merged commit 4d8a0d7 into MicrosoftDocs:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author do-not-merge masm/subsvc qualifies-for-auto-merge visual-cpp/svc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nir9 @Court72 @TylerMSFT