Fix the description of the _MBC_ILLEGAL return value, especially so in the case type == _MBC_LEAD.#5082
Merged
Conversation
…n the case `type == _MBC_LEAD`.
Contributor
|
@WilliamCushing : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 7a3dba4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
TylerMSFT
approved these changes
Aug 16, 2024
Collaborator
|
#sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add english descriptions of the conditions that results in illegality, and spell out the value ranges in positive fashion rather than negative fashion based on the values shown in the other rows.
Note that the table does not demonstrate locale-sensitivity or codepage-sensitivity; are the given example values the ones used for codepage 932 (japanese kanji)? Does locale really effect _mbbtype?