Skip to content

Fix documentation of /DEBUG:FASTLINK and plain /DEBUG.#4783

Merged
Jak-MS merged 1 commit into
MicrosoftDocs:mainfrom
davidmatson:fixDebugFastLinkDocs
Oct 26, 2023
Merged

Fix documentation of /DEBUG:FASTLINK and plain /DEBUG.#4783
Jak-MS merged 1 commit into
MicrosoftDocs:mainfrom
davidmatson:fixDebugFastLinkDocs

Conversation

@davidmatson

@davidmatson davidmatson commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

From discussion with the product team, /DEBUG means the same thing as /DEBUG:FULL. This has been the case for the linker itself since at least VS 2013 and is currently the case with all templates. Remove statements that indicated /DEBUG sometimes meant /DEBUG:FASTLINK.

Also, recommend not using /DEBUG:FASTLINK, per the product team.

@prmerger-automator

prmerger-automator Bot commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

@davidmatson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

learn-build-service-prod Bot commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 27fc9f5:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/debug-generate-debug-info.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS

Jak-MS commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

@TylerMSFT

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Oct 26, 2023
TylerMSFT
TylerMSFT approved these changes Oct 26, 2023
View reviewed changes

@TylerMSFT TylerMSFT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the date metadata at the top of the file?
This is a meaningful change so we should update the date to reflect that it's the latest info.
This is a welcome update - thank you.

@davidmatson

davidmatson commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

I assume that's just the ms.date? If so, done. (If not, please let me know the right way.)

@learn-build-service-prod

learn-build-service-prod Bot commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit c24954f:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/debug-generate-debug-info.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT

TylerMSFT commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

Perfecto. Thank you, @davidmatson
#sign-off

@Jak-MS Jak-MS merged commit 6100a45 into MicrosoftDocs:main Oct 26, 2023
@davidmatson davidmatson deleted the fixDebugFastLinkDocs branch October 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-tools/tech qualifies-for-auto-merge ready-to-merge visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmatson @Jak-MS @TylerMSFT