Skip to content

Update C2534#4756

Merged
American-Dipper merged 3 commits intoMicrosoftDocs:mainfrom
Rageking8:update-c2534
Oct 16, 2023
Merged

Update C2534#4756
American-Dipper merged 3 commits intoMicrosoftDocs:mainfrom
Rageking8:update-c2534

Conversation

@Rageking8
Copy link
Copy Markdown
Contributor

@Rageking8 Rageking8 commented Oct 8, 2023

Be slightly more explicit that return; is allowed and add a little more info should the user attempt to return an expression of type void.

@prmerger-automator prmerger-automator bot requested a review from TylerMSFT October 8, 2023 10:08
@prmerger-automator
Copy link
Copy Markdown
Contributor

prmerger-automator bot commented Oct 8, 2023

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod bot commented Oct 8, 2023

Learn Build status updates of commit 8432983:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2534.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

prmerger-automator bot commented Oct 8, 2023

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Copy Markdown
Contributor

Court72 commented Oct 9, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 9, 2023
Court72
Court72 reviewed Oct 9, 2023
View reviewed changes
@Rageking8 @Court72
Remove H2 heading
387e77c 
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod bot commented Oct 9, 2023

Learn Build status updates of commit 387e77c:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2534.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

prmerger-automator bot commented Oct 9, 2023

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Rageking8
Copy link
Copy Markdown
Contributor Author

Rageking8 commented Oct 9, 2023

Did not realize using the suggestion commit left an empty line, fixed it.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod bot commented Oct 9, 2023

Learn Build status updates of commit da610dc:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2534.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

prmerger-automator bot commented Oct 9, 2023

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

TylerMSFT
TylerMSFT approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TylerMSFT
Copy link
Copy Markdown
Collaborator

TylerMSFT commented Oct 16, 2023

#sign-off

@American-Dipper American-Dipper merged commit d2c5bb4 into MicrosoftDocs:main Oct 16, 2023
@Rageking8 Rageking8 deleted the update-c2534 branch November 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Court72 Court72 Court72 left review comments

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-diagnostics/tech needs-human-review ready-to-merge visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rageking8 @Court72 @TylerMSFT @American-Dipper