CC74711: Wrong reference to CONTRIBUTING.md#468
Closed
v-makoud wants to merge 1 commit intoMicrosoftDocs:masterfrom
Closed
CC74711: Wrong reference to CONTRIBUTING.md#468v-makoud wants to merge 1 commit intoMicrosoftDocs:masterfrom
v-makoud wants to merge 1 commit intoMicrosoftDocs:masterfrom
Conversation
Hello, @ghogen, @Taojunshen, @corob-msft, This proposed file change comes from https://github.com/MicrosoftDocs/cpp-docs.de-de/pull/9 . Could you review this contribution and help to merge if agreed? Many thanks in advance.
Contributor
|
@v-makoud : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
Contributor
|
@v-makoud This seems to work in GitHub without the change. Is that not true in the language-specific repos? |
Contributor
|
@v-makoud It looks like the real issue is that the de-de repo does not have a localized copy of CONTRIBUTING.md, which is what the fix in MicrosoftDocs/cpp-docs.de-de#9 is trying to remedy by linking to the primary repo's English version. The right change would be to localize CONTRIBUTING, or if that's not possible, then to make a localized file-only change along the lines of the fix above. |
Contributor
|
Thanks @corob-msft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @ghogen, @Taojunshen, @corob-msft,
This proposed file change comes from https://github.com/MicrosoftDocs/cpp-docs.de-de/pull/9 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.