Skip to content

There is no '&&=' operator#454

Merged
colin-home merged 2 commits intoMicrosoftDocs:masterfrom
simnalamburt:issue-448
Oct 12, 2018
Merged

There is no '&&=' operator#454
colin-home merged 2 commits intoMicrosoftDocs:masterfrom
simnalamburt:issue-448

Conversation

@simnalamburt
Copy link
Copy Markdown
Contributor

@simnalamburt simnalamburt commented Oct 7, 2018

Closes #448

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 7, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@PRMerger16
Copy link
Copy Markdown
Contributor

PRMerger16 commented Oct 7, 2018

@simnalamburt : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

mikeblome
mikeblome previously requested changes Oct 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikeblome mikeblome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simnalamburt looks good except the change to the remarks. There is a move assignment operation, which occurs when the = operator is applied to an rvalue reference. Let's leave that paragraph as-is.

colin-home
colin-home approved these changes Oct 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simnalamburt @mikeblome The remarks change looks fine for this topic, which is about the built-in assignment operators. The copy assignment and move assignment operators are described in their own topics.

@simnalamburt simnalamburt mentioned this pull request Oct 9, 2018
Closed
@simnalamburt
Copy link
Copy Markdown
Contributor Author

simnalamburt commented Oct 9, 2018

Move assignment operator is just one of possible overloading of simple assignment operator (operator=()) for class types. There's no guarantee that no copy will occur when operator=(T &&rhs) is called.

@GitHubber17
Copy link
Copy Markdown
Contributor

GitHubber17 commented Oct 9, 2018

@corob-msft @mikeblome - Please add an appropriate comment to indicate what action the review team should take on this PR, such as #sign-off or #please-close. Thank you.

Update assignment-operators.md
c2e732d 
Fix formatting issues and add links for copy assignment and move assignment.
@PRMerger15
Copy link
Copy Markdown
Contributor

PRMerger15 commented Oct 12, 2018

@corob-msft : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

@colin-home colin-home dismissed mikeblome’s stale review October 12, 2018 20:39

Fixed with links to relevant topics.

@colin-home colin-home merged commit a6a9584 into MicrosoftDocs:master Oct 12, 2018
@simnalamburt simnalamburt deleted the issue-448 branch October 13, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@colin-home colin-home colin-home approved these changes

@mikeblome mikeblome mikeblome left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Change sent to author do-not-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@simnalamburt @msftclas @PRMerger16 @GitHubber17 @PRMerger15 @colin-home @mikeblome