Skip to content

example needed to mitigate dev floundering - #4210

Merged
Tyler Whitney (TylerMSFT) merged 1 commit into
MicrosoftDocs:mainfrom
rtischer8277:patch-3
Oct 11, 2022
Merged

Tyler Whitney (TylerMSFT) merged 1 commit into
MicrosoftDocs:mainfrom
rtischer8277:patch-3

Conversation

@rtischer8277

Copy link
Copy Markdown
Contributor

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.
@prmerger-automator

Copy link
Copy Markdown
Contributor

rtischer8277 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld31

opbld31 commented Oct 11, 2022

Copy link
Copy Markdown

Learn Build status updates of commit 47e995c:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT)

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Oct 11, 2022

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtischer8277 , thank you very much for adding to the docs! We really appreciate that you'd take the time to add your learnings to the doc. There are some minor stylistic things in terms of spacing, and we prefer to say if (property != null) instead of if (property). But these are small things and I'll update them later. The important thing is the example you contributed and I'm approving your changes so we can get them in and published tomorrow. Thank you!

@TylerMSFT

Copy link
Copy Markdown
Collaborator

#sign-off

@TylerMSFT
Tyler Whitney (TylerMSFT) merged commit 18a064d into MicrosoftDocs:main Oct 11, 2022
Martin Storsjö (mstorsjo) pushed a commit to mstorsjo/cpp-docs that referenced this pull request Oct 12, 2022
…-non-blocking

Address non-blocking issues from 4207
@rtischer8277
rtischer8277 deleted the patch-3 branch October 12, 2022 13:53
opbld17 added a commit that referenced this pull request Oct 12, 2022
* Document ARM64 unwind handling for return address signing

* Update date, fix step numbers

* Fix style, grammar in Arm64 Exception

* Rename pac_sign_lr and update reserved ranges.

* example needed to mitigate dev floundering (#4210)

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

* Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#4571)

* 10/11/2022 AM Publish (#4570)

* Document ARM64 unwind handling for return address signing

* Update date, fix step numbers

* Fix style, grammar in Arm64 Exception

Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>

* example needed to mitigate dev floundering (#4210)

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

Co-authored-by: Taojunshen <v-jutao@microsoft.com>
Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: rtischer8277 <rtischer@hiveware.com>

Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: Pedro Miguel Justo <40605312+pmsjt@users.noreply.github.com>
Co-authored-by: rtischer8277 <rtischer@hiveware.com>
Co-authored-by: Feng Xu <fenxu@microsoft.com>
opbld15 added a commit that referenced this pull request Oct 13, 2022
* Document ARM64 unwind handling for return address signing

* Update date, fix step numbers

* Fix style, grammar in Arm64 Exception

* Rename pac_sign_lr and update reserved ranges.

* example needed to mitigate dev floundering (#4210)

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

* Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#4571)

* 10/11/2022 AM Publish (#4570)

* Document ARM64 unwind handling for return address signing

* Update date, fix step numbers

* Fix style, grammar in Arm64 Exception

Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>

* example needed to mitigate dev floundering (#4210)

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

Co-authored-by: Taojunshen <v-jutao@microsoft.com>
Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: rtischer8277 <rtischer@hiveware.com>

* cleanup empty remarks and tidy up code example formatting

* Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#4573)

* Use the correct canonical opcode name in the packed unwind table

This was a leftover from the original tentative name before the
real one was known.

* Correct Month range in `ok` member description (#4215)

Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: Christopher Doyle <christophercormac@outlook.com>

Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: Pedro Miguel Justo <40605312+pmsjt@users.noreply.github.com>
Co-authored-by: rtischer8277 <rtischer@hiveware.com>
Co-authored-by: Feng Xu <fenxu@microsoft.com>
Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com>
Co-authored-by: Christopher Doyle <christophercormac@outlook.com>
Co-authored-by: Linda Spiller <93278958+LJSpiller@users.noreply.github.com>
opbld15 added a commit that referenced this pull request Oct 14, 2022
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#4571)

* 10/11/2022 AM Publish (#4570)

* Document ARM64 unwind handling for return address signing

* Update date, fix step numbers

* Fix style, grammar in Arm64 Exception

Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>

* example needed to mitigate dev floundering (#4210)

It is not easy to match up variant vt types with POD types. Especially since there is a gradual transition to modern C++. I used a number of dev hours on attempts to match the variant type, vt, to make the true/false work. The m_bValue type for the simple property was a BOOL  type, but trying to create a variant of type BOOL directly didn't work. Only by looking at VC Sample code for VisualStudioDemo did I see the (_variant_t)true construct, which becomes the standard_cast contruct in modern C++. I figured my Example code could make other programmer's efforts easier.

Co-authored-by: Taojunshen <v-jutao@microsoft.com>
Co-authored-by: opbld17 <opbld17@microsoft.com>
Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com>
Co-authored-by: opbld16 <opbld16@microsoft.com>
Co-authored-by: opbld15 <opbld15@microsoft.com>
Co-authored-by: Martin Storsjö <martin@martin.st>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: rtischer8277 <rtischer@hiveware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants