Skip to content

Rename pac_sign_lr and update reserved ranges. - #4209

Merged
Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:mainfrom
pmsjt:patch-1
Oct 12, 2022
Merged

Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:mainfrom
pmsjt:patch-1

Conversation

@pmsjt

Copy link
Copy Markdown
Contributor

No description provided.

@prmerger-automator

Copy link
Copy Markdown
Contributor

Pedro Miguel Justo (@pmsjt) : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld31

opbld31 commented Oct 11, 2022

Copy link
Copy Markdown

Learn Build status updates of commit cac237d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72

Copy link
Copy Markdown
Contributor

@corob-msft

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Oct 11, 2022
@opbld31

opbld31 commented Oct 12, 2022

Copy link
Copy Markdown

Learn Build status updates of commit eb36c0a:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home

Copy link
Copy Markdown
Contributor

Pedro Miguel Justo (@pmsjt)
Thanks for the expansion. While the compact opcode name appears to be arbitrary, and isn't documented anywhere else, is there a reason other than terseness for choosing pac_sign_lr? At least one internal tool appears to dump the compact opcode as "PAC_SIGN_RETURN_ADDRESS". The linker dumps the compact opcodes as their regular opcode equivalents, so it doesn't get exposed that way.

@pmsjt

Pedro Miguel Justo (pmsjt) commented Oct 12, 2022 •

Copy link
Copy Markdown
Contributor Author

Pedro Miguel Justo (@pmsjt) Thanks for the expansion. While the compact opcode name appears to be arbitrary, and isn't documented anywhere else, is there a reason other than terseness for choosing pac_sign_lr? At least one internal tool appears to dump the compact opcode as "PAC_SIGN_RETURN_ADDRESS". The linker dumps the compact opcodes as their regular opcode equivalents, so it doesn't get exposed that way.

Unwind opcode names are usually short. The previous name stood out like a sore thumb. The rename makes it more consistent with the rest of the naming scheme.

Martin Storsjö (mstorsjo) pushed a commit to mstorsjo/cpp-docs that referenced this pull request Oct 12, 2022
@colin-home
Colin Robertson (colin-home) merged commit 0bd04f6 into MicrosoftDocs:main Oct 12, 2022
Martin Storsjö (mstorsjo) added a commit to llvm/llvm-project that referenced this pull request Oct 12, 2022
This new opcode was initially documented as "pac_sign_return_address"
in MicrosoftDocs/cpp-docs#4202, but was
soon afterwards renamed into "pac_sign_lr" in
MicrosoftDocs/cpp-docs#4209, as the other
name was unwieldy, and there were no other external references to
that name anywhere.

Rename our external .seh assembler directive - it hasn't been merged
for very long yet, so there's probably no external use to account for.

Rename all other internal references to the opcode similarly.

Differential Revision: https://reviews.llvm.org/D135762
Petr Vesely (veselypeta) pushed a commit to veselypeta/cherillvm that referenced this pull request May 28, 2024
This new opcode was initially documented as "pac_sign_return_address"
in MicrosoftDocs/cpp-docs#4202, but was
soon afterwards renamed into "pac_sign_lr" in
MicrosoftDocs/cpp-docs#4209, as the other
name was unwieldy, and there were no other external references to
that name anywhere.

Rename our external .seh assembler directive - it hasn't been merged
for very long yet, so there's probably no external use to account for.

Rename all other internal references to the opcode similarly.

Differential Revision: https://reviews.llvm.org/D135762
Ashlyn (paleauraaaa) pushed a commit to paleauraaaa/llvm-project that referenced this pull request Oct 7, 2026
This new opcode was initially documented as "pac_sign_return_address"
in MicrosoftDocs/cpp-docs#4202, but was
soon afterwards renamed into "pac_sign_lr" in
MicrosoftDocs/cpp-docs#4209, as the other
name was unwieldy, and there were no other external references to
that name anywhere.

Rename our external .seh assembler directive - it hasn't been merged
for very long yet, so there's probably no external use to account for.

Rename all other internal references to the opcode similarly.

Differential Revision: https://reviews.llvm.org/D135762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants