Skip to content

Update walkthrough-creating-and-using-a-dynamic-link-library-cpp.md#4027

Closed
garlfield wants to merge 1 commit into
MicrosoftDocs:mainfrom
garlfield:patch-1
Closed

Update walkthrough-creating-and-using-a-dynamic-link-library-cpp.md#4027
garlfield wants to merge 1 commit into
MicrosoftDocs:mainfrom
garlfield:patch-1

Conversation

@garlfield

Copy link
Copy Markdown

Add description of precompiler steps in case the project name does not match.

Add description of precompiler steps in case the project name does not match.
@PRMerger17

Copy link
Copy Markdown
Contributor

@garlfield : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld33

opbld33 commented Jul 6, 2022

Copy link
Copy Markdown

Docs Build status updates of commit ae5424d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Jak-MS

Jak-MS commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

@corob-msft

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@PRMerger5 PRMerger5 added the aq-pr-triaged Tracking label for the PR review team label Jul 6, 2022
@colin-home

Copy link
Copy Markdown
Contributor

@garlfield
Thanks for being extremely patient.

Looking at your addition, it's good to know how to set preprocessor definitions in your project properties. However, I'm having trouble with the idea that you'd ever need to change the <PROJECTNAME>_EXPORTS value in the middle of this walkthrough. If you create a new project with your preferred name, say, MyNewLibrary, that name will also be used in the preprocessor macros generated by the template, such as MYNEWLIBRARY_EXPORTS. You won't need to edit them after the fact. The only time you'd need the step you described is if you've decided to change the project name after creating the project, and you want everything to match - which is outside of the scope of the walkthrough.

It pains me to reject a submission, and the generous work it represents, but I'll need more convincing about its utility before I adopt this change. Feel free to make your case in comments below. For now, I'm closing the PR.

@opbld30

opbld30 commented Aug 5, 2022

Copy link
Copy Markdown

Docs Build status updates of commit ae5424d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants