Add io.h header into example code#3343
Closed
NikoAri wants to merge 1 commit into
Closed
Conversation
Repro: 1. Paste sample code for _get_errno is placed into new Visual Studio 2019 project 1. Try to compile Result: Compilation fails The error is: Error C3861 '_sopen_s': identifier not found Expected Result: Sample code should just compile Fix: Add io.h header file to avoid the above error in sample code.
Contributor
|
@NikoAri : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
TylerMSFT
requested changes
Sep 1, 2021
TylerMSFT
left a comment
TylerMSFT
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @NikoAri! Really appreciate you not only seeing what's wrong, but fixing it. That's fantastic.
Your changes are good. If you want, you could also remove #include <share.h> as part of this, I think. If you'd like to do that, I'll approve the changes right after.
Contributor
Author
|
Created new PR with requested change: |
Contributor
Author
|
New PR Link: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
Result:
Compilation fails
The error is:
Error C3861 '_sopen_s': identifier not found
Expected Result:
Sample code should just compile
Fix:
Add io.h header file to avoid the above error in sample code.