Skip to content

typo in code example#3323

Merged
ktoliver merged 3 commits into
MicrosoftDocs:masterfrom
BugCheck141:patch-1
Aug 30, 2021
Merged

typo in code example#3323
ktoliver merged 3 commits into
MicrosoftDocs:masterfrom
BugCheck141:patch-1

Conversation

@BugCheck141

Copy link
Copy Markdown
Contributor

No description provided.

@PRMerger13

Copy link
Copy Markdown
Contributor

@sudoerChris : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Updated some code escapes for localization
@ghost

ghost commented Aug 25, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@TylerMSFT TylerMSFT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sudoerChris! We appreciate you taking the time to improve the docs.
I updated the date tag for the file and added some code escapes that the file should have had originally to prevent over machine translation since the file was being edited already.

@TylerMSFT

Copy link
Copy Markdown
Collaborator

@sudoerChris, can you click the button to sign the Contributor License Agreement (search "like many" and you'll find it in the conversation above). Then I can get this through. Sorry for the inconvenience :-|

@BugCheck141

Copy link
Copy Markdown
Contributor Author

@TylerMSFT The CLA page shows the following error message:
Error
There is no CLA to sign for MicrosoftDocs/cpp-docs
({"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"})

@TylerMSFT

Copy link
Copy Markdown
Collaborator

@sudoerChris , Let me see what I can do to get your contribution through. Sorry for the unnecessary friction. First time I've seen this - not sure what is causing it.

@ktoliver

ktoliver commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

I'll open a bug.

image

cc @tfosmark @v-lmcdonald

@ktoliver

ktoliver commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

CLA Assistant Bug: https://ceapex.visualstudio.com/Engineering/_workitems/edit/478855 (Microsoft-internal link)

@ktoliver

Copy link
Copy Markdown
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ sudoerChris sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@sudoerChris It looks like the CLA page is working now. Would you give it a try? Thanks!

@TylerMSFT

Copy link
Copy Markdown
Collaborator

@sudoerchris, sorry for the hassle on the license thing. Could you give signing the CLA page another go? Would love to get your changes in.

@PRMerger16 PRMerger16 requested a review from TylerMSFT August 30, 2021 16:22
@PRMerger16

Copy link
Copy Markdown
Contributor

@TylerMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@BugCheck141

Copy link
Copy Markdown
Contributor Author

@TylerMSFT done, thx for your help!

@PRMerger18

Copy link
Copy Markdown
Contributor

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver merged commit 1176d74 into MicrosoftDocs:master Aug 30, 2021
@BugCheck141 BugCheck141 deleted the patch-1 branch August 30, 2021 16:52
@TylerMSFT

Copy link
Copy Markdown
Collaborator

Thank you @ktoliver and @sudoerChris for getting this through. Sorry about the CLA friction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants